Re: [PATCH 01/16] remote-helpers: avoid has_key

2013-04-22 Thread Dusty Phillips
On 04/22/2013 04:35 PM, Felipe Contreras wrote: On Mon, Apr 22, 2013 at 5:28 PM, Junio C Hamano wrote: Felipe Contreras writes: From: Dusty Phillips It is deprecated. [fc: do the same in remote-bzr] Signed-off-by: Felipe Contreras --- No sign-off by the author? It does not matter for

Re: [PATCH 01/16] remote-helpers: avoid has_key

2013-04-22 Thread Felipe Contreras
On Mon, Apr 22, 2013 at 5:28 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> From: Dusty Phillips >> >> It is deprecated. >> >> [fc: do the same in remote-bzr] >> >> Signed-off-by: Felipe Contreras >> --- > > No sign-off by the author? > > It does not matter for something so trivial l

Re: [PATCH 01/16] remote-helpers: avoid has_key

2013-04-22 Thread Junio C Hamano
Felipe Contreras writes: > From: Dusty Phillips > > It is deprecated. > > [fc: do the same in remote-bzr] > > Signed-off-by: Felipe Contreras > --- No sign-off by the author? It does not matter for something so trivial like this that there is no other way to write, but it is a good habit you

[PATCH 01/16] remote-helpers: avoid has_key

2013-04-22 Thread Felipe Contreras
From: Dusty Phillips It is deprecated. [fc: do the same in remote-bzr] Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-bzr | 2 +- contrib/remote-helpers/git-remote-hg | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/remote-helpers/git-remo