Re: [PATCH 01/11] diff: use hashmap_entry_init on moved_entry.ent

2019-08-27 Thread Derrick Stolee
On 8/25/2019 10:43 PM, Eric Wong wrote: > Otherwise, the hashmap_entry.next field appears to remain > uninitialized, which can lead to problems when > add_lines_to_move_detection calls hashmap_add. > > I found this through manual inspection when converting > hashmap_add callers to take "struct has

[PATCH 01/11] diff: use hashmap_entry_init on moved_entry.ent

2019-08-25 Thread Eric Wong
Otherwise, the hashmap_entry.next field appears to remain uninitialized, which can lead to problems when add_lines_to_move_detection calls hashmap_add. I found this through manual inspection when converting hashmap_add callers to take "struct hashmap_entry *". Signed-off-by: Eric Wong --- diff.