Re: [PATCH 01/10] ref-filter: add option to filter only branches

2015-08-14 Thread Karthik Nayak
On Fri, Aug 14, 2015 at 9:26 PM, Junio C Hamano wrote: > Karthik Nayak writes: > >> On Thu, Aug 13, 2015 at 5:05 PM, Karthik Nayak wrote: >>> On Thu, Aug 13, 2015 at 4:21 PM, Karthik Nayak >>> wrote: This was taken from branch.c, I thought of using an enum instead but that would

Re: [PATCH 01/10] ref-filter: add option to filter only branches

2015-08-14 Thread Junio C Hamano
Karthik Nayak writes: > On Thu, Aug 13, 2015 at 5:05 PM, Karthik Nayak wrote: >> On Thu, Aug 13, 2015 at 4:21 PM, Karthik Nayak wrote: >>> >>> This was taken from branch.c, I thought of using an enum instead but that >>> would again require most of branch.c, hence it's been carried over >>> wit

Re: [PATCH 01/10] ref-filter: add option to filter only branches

2015-08-13 Thread Karthik Nayak
On Thu, Aug 13, 2015 at 10:22 PM, Matthieu Moy wrote: > > > Le 13 août 2015 13:35:21 GMT+02:00, Karthik Nayak a > écrit : >>On Thu, Aug 13, 2015 at 4:21 PM, Karthik Nayak >>wrote: >>> >>> This was taken from branch.c, I thought of using an enum instead but >>that >>> would again require most of

Re: [PATCH 01/10] ref-filter: add option to filter only branches

2015-08-13 Thread Matthieu Moy
Le 13 août 2015 13:35:21 GMT+02:00, Karthik Nayak a écrit : >On Thu, Aug 13, 2015 at 4:21 PM, Karthik Nayak >wrote: >> >> This was taken from branch.c, I thought of using an enum instead but >that >> would again require most of branch.c, hence it's been carried over >> without changing >> I'm

Re: [PATCH 01/10] ref-filter: add option to filter only branches

2015-08-13 Thread Karthik Nayak
On Thu, Aug 13, 2015 at 5:05 PM, Karthik Nayak wrote: > On Thu, Aug 13, 2015 at 4:21 PM, Karthik Nayak wrote: >> >> This was taken from branch.c, I thought of using an enum instead but that >> would again require most of branch.c, hence it's been carried over >> without changing >> I'm thinking o

Re: [PATCH 01/10] ref-filter: add option to filter only branches

2015-08-13 Thread Karthik Nayak
On Thu, Aug 13, 2015 at 4:21 PM, Karthik Nayak wrote: > > This was taken from branch.c, I thought of using an enum instead but that > would again require most of branch.c, hence it's been carried over > without changing > I'm thinking of changing it, any suggestions? > What I was thinking was of

Re: [PATCH 01/10] ref-filter: add option to filter only branches

2015-08-13 Thread Karthik Nayak
On Tue, Aug 11, 2015 at 11:03 PM, Junio C Hamano wrote: > Karthik Nayak writes: > >> From: Karthik Nayak >> >> Add an option in 'filter_refs()' to use 'for_each_branch_ref()' >> and filter refs. This type checking is done by adding a >> 'FILTER_REFS_BRANCHES' in 'ref-filter.h'. >> >> Add an opti

Re: [PATCH 01/10] ref-filter: add option to filter only branches

2015-08-11 Thread Junio C Hamano
Karthik Nayak writes: > From: Karthik Nayak > > Add an option in 'filter_refs()' to use 'for_each_branch_ref()' > and filter refs. This type checking is done by adding a > 'FILTER_REFS_BRANCHES' in 'ref-filter.h'. > > Add an option in 'ref_filter_handler()' to filter different > types of branche

[PATCH 01/10] ref-filter: add option to filter only branches

2015-08-04 Thread Karthik Nayak
From: Karthik Nayak Add an option in 'filter_refs()' to use 'for_each_branch_ref()' and filter refs. This type checking is done by adding a 'FILTER_REFS_BRANCHES' in 'ref-filter.h'. Add an option in 'ref_filter_handler()' to filter different types of branches by calling 'filter_branch_kind()' wh