Re: [PATCH 00/76] Convert diff opt parser to parse_options()

2019-01-17 Thread Stefan Beller
On Thu, Jan 17, 2019 at 6:33 AM Ævar Arnfjörð Bjarmason wrote: > > I sent a sneak peek [1] last year and got two good comments. I take it > > people at least did not oppose to this. The most interesting parts are > > at the top and bottom. The middle is just boring conversion, usually > > one opt

Re: [PATCH 00/76] Convert diff opt parser to parse_options()

2019-01-17 Thread Ævar Arnfjörð Bjarmason
On Thu, Jan 17 2019, Nguyễn Thái Ngọc Duy wrote: > This series converts diff option parsing to using parse-options. There > are a couple benefits of using parse-options, including "git -h" > output, completion and less duplicate work. > > This is the first half. The second one would be converti

[PATCH 00/76] Convert diff opt parser to parse_options()

2019-01-17 Thread Nguyễn Thái Ngọc Duy
This series converts diff option parsing to using parse-options. There are a couple benefits of using parse-options, including "git -h" output, completion and less duplicate work. This is the first half. The second one would be converting the option parser in revision.c. After that, the end game