Re: [PATCH 00/52] fix some -Wmissing-field-initializer warnings

2019-05-30 Thread Ramsay Jones
On 30/05/2019 13:04, Jeff King wrote: > On Thu, May 30, 2019 at 10:47:37AM +0200, Johannes Sixt wrote: > >> I had a brief look at the series. IMO, it is a mistake to appease >> -Wmissing-field-initializer. >> >> We have two sorts of initializers: >> >> - zero initializers: they just want to nu

Re: [PATCH 00/52] fix some -Wmissing-field-initializer warnings

2019-05-30 Thread Jeff King
On Thu, May 30, 2019 at 10:47:37AM +0200, Johannes Sixt wrote: > I had a brief look at the series. IMO, it is a mistake to appease > -Wmissing-field-initializer. > > We have two sorts of initializers: > > - zero initializers: they just want to null out every field, >like CHILD_PROCESS_INIT

Re: [PATCH 00/52] fix some -Wmissing-field-initializer warnings

2019-05-30 Thread Johannes Sixt
Hi Ramsay, I had a brief look at the series. IMO, it is a mistake to appease -Wmissing-field-initializer. We have two sorts of initializers: - zero initializers: they just want to null out every field, like CHILD_PROCESS_INIT and ad-hoc initializers of structs such as xpparam_t pp = { 0 }

Re: [PATCH 00/52] fix some -Wmissing-field-initializer warnings

2019-05-24 Thread Ramsay Jones
On 24/05/2019 23:30, Ævar Arnfjörð Bjarmason wrote: > > On Fri, May 24 2019, Ramsay Jones wrote: > >> [No, I won't be sending 52 patches to the list!] >> [...] >> This series does not fix any problems or add any new features, so it >> is not important (hence the tendency to 'slip'). I don't wa

Re: [PATCH 00/52] fix some -Wmissing-field-initializer warnings

2019-05-24 Thread Ævar Arnfjörð Bjarmason
On Fri, May 24 2019, Ramsay Jones wrote: > [No, I won't be sending 52 patches to the list!] > [...] > This series does not fix any problems or add any new features, so it > is not important (hence the tendency to 'slip'). I don't want to > flood the mailing list with patches that nobody wants, s

[PATCH 00/52] fix some -Wmissing-field-initializer warnings

2019-05-24 Thread Ramsay Jones
[No, I won't be sending 52 patches to the list!] This series, started last year, has been hanging around because the time never seemed right to send it to the list. It may still not be the right time ... :-D I would like to be able to compile git using '-Wall -Wextra -Werror' compiler options.