Re: [PATCH 00/35] refactoring refspecs

2018-05-15 Thread Brandon Williams
On 05/15, Ævar Arnfjörð Bjarmason wrote: > > On Mon, May 14 2018, Brandon Williams wrote: > > > When working on protocol v2 I noticed that working with refspecs was a > > little difficult because of the various api's that existed. Some > > functions expected an array of "const char *" while othe

Re: [PATCH 00/35] refactoring refspecs

2018-05-15 Thread Ævar Arnfjörð Bjarmason
On Mon, May 14 2018, Brandon Williams wrote: > When working on protocol v2 I noticed that working with refspecs was a > little difficult because of the various api's that existed. Some > functions expected an array of "const char *" while others expected an > array of "struct refspec". In all c

Re: [PATCH 00/35] refactoring refspecs

2018-05-15 Thread Junio C Hamano
Brandon Williams writes: > This series refactors how refspecs are handled through out the code base > by renaming the existing struct refspec to refspec_item and introducing > a new 'struct refspec' which is a container of refspec_items, much like > how a pathspec contains pathspec_items. This s

Re: [PATCH 00/35] refactoring refspecs

2018-05-14 Thread Stefan Beller
> 22 files changed, 514 insertions(+), 571 deletions(-) > create mode 100644 refspec.c > create mode 100644 refspec.h This looks promising. I'll hope to find time to review it. Stefan

[PATCH 00/35] refactoring refspecs

2018-05-14 Thread Brandon Williams
When working on protocol v2 I noticed that working with refspecs was a little difficult because of the various api's that existed. Some functions expected an array of "const char *" while others expected an array of "struct refspec". In all cases a length parameter needed to be passed as a parame