Re: [PATCH 00/14] Remove unused code from imap-send.c

2013-01-14 Thread Junio C Hamano
Michael Haggerty writes: > On 01/14/2013 07:57 AM, Jonathan Nieder wrote: >> Michael Haggerty wrote: >> >>> imap-send.c | 286 >>> +--- >>> 1 file changed, 39 insertions(+), 247 deletions(-) >> >> See my replies for comments on patches 1

Re: [PATCH 00/14] Remove unused code from imap-send.c

2013-01-14 Thread Michael Haggerty
On 01/14/2013 07:57 AM, Jonathan Nieder wrote: > Michael Haggerty wrote: > >> imap-send.c | 286 >> +--- >> 1 file changed, 39 insertions(+), 247 deletions(-) > > See my replies for comments on patches 1, 6, 9, 11, and 12. The rest > are

Re: [PATCH 00/14] Remove unused code from imap-send.c

2013-01-13 Thread Jonathan Nieder
Michael Haggerty wrote: > imap-send.c | 286 > +--- > 1 file changed, 39 insertions(+), 247 deletions(-) See my replies for comments on patches 1, 6, 9, 11, and 12. The rest are Reviewed-by: Jonathan Nieder The series is tasteful and e

Re: [PATCH 00/14] Remove unused code from imap-send.c

2013-01-13 Thread Jeff King
On Mon, Jan 14, 2013 at 06:32:32AM +0100, Michael Haggerty wrote: > As discussed before [1], imap-send.c was copied from isync, including > a lot of code that is not used within the git project. This patch > series rips a bunch of it out. Thanks, this looks like a good direction. I did not noti

[PATCH 00/14] Remove unused code from imap-send.c

2013-01-13 Thread Michael Haggerty
As discussed before [1], imap-send.c was copied from isync, including a lot of code that is not used within the git project. This patch series rips a bunch of it out. [1] http://comments.gmane.org/gmane.comp.version-control.git/210355 Michael Haggerty (14): imap-send.c: remove msg_data::flags,