Elijah Newren writes:
>>
>> But please remind me not to merge this round down to 'next', for the
>> "enum" forward decl gotcha.
>
> I'll send out a new round shortly. Would you like me to squash the
> last patch (the one that had two hunks with minor conflicts with other
> topics in next and pu)
On Wed, Aug 15, 2018 at 8:43 AM Junio C Hamano wrote:
> Elijah Newren writes:
>
> > On Tue, Aug 14, 2018 at 10:45 PM Junio C Hamano wrote:
> >> Elijah Newren writes:
> >>
> >> > On Mon, Aug 13, 2018 at 11:24 AM Junio C Hamano
> >> > wrote:
> >> >> Jeff King writes:
> >> >
> >> >> As things a
Elijah Newren writes:
> On Tue, Aug 14, 2018 at 10:45 PM Junio C Hamano wrote:
>> Elijah Newren writes:
>>
>> > On Mon, Aug 13, 2018 at 11:24 AM Junio C Hamano wrote:
>> >> Jeff King writes:
>> >
>> >> As things are slowly moving out of the so-far kitchen-sink "cache.h"
>> >> into more specif
On Tue, Aug 14, 2018 at 10:45 PM Junio C Hamano wrote:
> Elijah Newren writes:
>
> > On Mon, Aug 13, 2018 at 11:24 AM Junio C Hamano wrote:
> >> Jeff King writes:
> >
> >> As things are slowly moving out of the so-far kitchen-sink "cache.h"
> >> into more specific subsystem headers (like object
Elijah Newren writes:
> On Mon, Aug 13, 2018 at 11:24 AM Junio C Hamano wrote:
>> Jeff King writes:
>
>> As things are slowly moving out of the so-far kitchen-sink "cache.h"
>> into more specific subsystem headers (like object-store.h), we may
>> actually want to tighten the "header that includ
Jeff King wrote:
> Subject: [PATCH] test-tool.h: include git-compat-util.h
>
> The test-tool programs include "test-tool.h" as their first
> include, which breaks our CodingGuideline of "the first
> include must be git-compat-util.h or an equivalent". This
> isn't actually a problem, as test-tool.
Jeff King wrote:
> On Mon, Aug 13, 2018 at 11:24:37AM -0700, Junio C Hamano wrote:
>> Jeff King wrote:
>>> So I think the better test is a two-line .c file with:
>>>
>>> #include "git-compat-util.h"
>>> #include $header_to_check
>>
>> But until that tightening happens, I do not actually mind t
On Mon, Aug 13, 2018 at 11:24:37AM -0700, Junio C Hamano wrote:
> As things are slowly moving out of the so-far kitchen-sink "cache.h"
> into more specific subsystem headers (like object-store.h), we may
> actually want to tighten the "header that includes it first" part a
> bit in the future, so
On Mon, Aug 13, 2018 at 11:24 AM Junio C Hamano wrote:
> Jeff King writes:
> As things are slowly moving out of the so-far kitchen-sink "cache.h"
> into more specific subsystem headers (like object-store.h), we may
> actually want to tighten the "header that includes it first" part a
> bit in th
Jeff King writes:
> The rule in Git has always been that your very first include must
> always be "git-compat-util.h" or an equivalent header that includes it
> first (like "cache.h"). This is mentioned in CodingGuidelines.
Glad to see that you already have written the above so I don't have
to ;
On Sat, Aug 11, 2018 at 01:59:50AM -0700, Elijah Newren wrote:
> The part of my story you snipped in the ellipsis is kind of important,
> though: "...and decided to determine which header files were missing
> their own necessary #include's and forward declarations." The way I
> did so was making
On Sat, Aug 11, 2018 at 1:30 AM Ævar Arnfjörð Bjarmason wrote
> On Sat, Aug 11 2018, Elijah Newren wrote:
>
> [CC'd sha1dc maintainers, for context the relevent patch is
> https://public-inbox.org/git/20180811043218.31456-8-new...@gmail.com/T/#u]
>
> > * Patches 6-8: These patches might need to
On Sat, Aug 11 2018, Elijah Newren wrote:
[CC'd sha1dc maintainers, for context the relevent patch is
https://public-inbox.org/git/20180811043218.31456-8-new...@gmail.com/T/#u]
> * Patches 6-8: These patches might need to be submitted to separate
> projects elsewhere. Let me know if so.
I was bit yet again by compilation errors when adding a #include of
some header file to some new place, and decided to determine which
header files were missing their own necessary #include's and forward
declarations. This patch series is the result. A few notes:
* Patch 1: This patch is the b
14 matches
Mail list logo
