Re: [PATCH 0/8] fix git-config with duplicate variable entries

2012-11-23 Thread Joachim Schmitz
Junio C Hamano wrote: Jeff King writes: ... Not exactly. There are three classes of people: - wrote scripts using --get; found out that --get barfs if you feed two or more of the same, and have long learned to accept it as a limitation and adjusted their configuration files to avoid it

Re: [PATCH 0/8] fix git-config with duplicate variable entries

2012-11-21 Thread Junio C Hamano
Jeff King writes: > So what do we want to do? Nothing. We'd just let it graduate along with other topics, and deal with a case where somebody screams, which is unlikely to happen ;-). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.ke

Re: [PATCH 0/8] fix git-config with duplicate variable entries

2012-11-21 Thread Jeff King
On Wed, Nov 21, 2012 at 11:46:33AM -0800, Junio C Hamano wrote: > > The problem is that scripts currently using "--get" are broken by > > duplicate entries in include files, whereas internal git handles them > > just fine. Introducing a new switch means that everybody also has to > > start using

Re: [PATCH 0/8] fix git-config with duplicate variable entries

2012-11-21 Thread Junio C Hamano
Jeff King writes: >> The way for the Porcelain scripts to mimick the internal "last one >> wins" has been to grab values out of --get-all and do the "last one >> wins" themselves, and I agree that a mode that frees them from >> having to worry about it is a good *addition*. I would even say >> t

Re: [PATCH 0/8] fix git-config with duplicate variable entries

2012-11-21 Thread Jeff King
On Tue, Nov 20, 2012 at 11:08:43AM -0800, Junio C Hamano wrote: > > Thanks. It had a few minor flaws (like a memory leak). I fixed those, > > updated the tests, and split it out into a few more readable commits. In > > the process, I managed to uncover and fix a few other memory leaks in > > the a

Re: [PATCH 0/8] fix git-config with duplicate variable entries

2012-11-20 Thread Junio C Hamano
Jeff King writes: > On Tue, Oct 23, 2012 at 04:13:44PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> > It fails a few tests in t1300, but it looks like those tests are testing >> > for the behavior we have identified as wrong, and should be fixed. >> >> I think this patch looks good. > > Thanks. It

[PATCH 0/8] fix git-config with duplicate variable entries

2012-10-23 Thread Jeff King
On Tue, Oct 23, 2012 at 04:13:44PM +0200, Ævar Arnfjörð Bjarmason wrote: > > It fails a few tests in t1300, but it looks like those tests are testing > > for the behavior we have identified as wrong, and should be fixed. > > I think this patch looks good. Thanks. It had a few minor flaws (like a