Re: [PATCH 0/7] teach branch-specific options for format-patch

2019-05-07 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > This may just be more insanity to implement right now, but perhaps in > addition to "gitdir:" etc. in the IncludeIf config syntax we'd want to > aim for "HEADref" (or some saner name). I.e. allowing to include/enable > arbitrary config based on the ref name. > >

Re: [PATCH 0/7] teach branch-specific options for format-patch

2019-05-07 Thread Ævar Arnfjörð Bjarmason
On Tue, May 07 2019, Denton Liu wrote: > On Wed, May 08, 2019 at 12:05:43AM +0900, Junio C Hamano wrote: >> Denton Liu writes: > > [snip] > >> > >> > Would you suggest moving to a format..* approach or would it >> > make sense to rename the configs to something like >> > branch..{emailCoverSubj

Re: [PATCH 0/7] teach branch-specific options for format-patch

2019-05-07 Thread Denton Liu
On Wed, May 08, 2019 at 12:05:43AM +0900, Junio C Hamano wrote: > Denton Liu writes: [snip] > > > > Would you suggest moving to a format..* approach or would it > > make sense to rename the configs to something like > > branch..{emailCoverSubject,emailTo,emailCc}? > > So if I have to pick betwe

Re: [PATCH 0/7] teach branch-specific options for format-patch

2019-05-07 Thread Junio C Hamano
Denton Liu writes: > The reason why I chose to use branch..* is because format-patch > currently reads from branch..description and I wanted to build on > top of that. In addition, I didn't want to scatter branch-specific > configs in two different place (i.e. have a branch..description > alongsi

Re: [PATCH 0/7] teach branch-specific options for format-patch

2019-05-07 Thread Denton Liu
Hi Junio, On Tue, May 07, 2019 at 05:56:00PM +0900, Junio C Hamano wrote: > Denton Liu writes: > > > Currently, format-patch only accepts branch..description as a > > branch-specific configuration variable. However, there are many other > > options which would be useful to have on a branch-by-bra

Re: [PATCH 0/7] teach branch-specific options for format-patch

2019-05-07 Thread Junio C Hamano
Denton Liu writes: > Currently, format-patch only accepts branch..description as a > branch-specific configuration variable. However, there are many other > options which would be useful to have on a branch-by-branch basis, > namely cover letter subject and To: and Cc: headers. > > Teach format-p

[PATCH 0/7] teach branch-specific options for format-patch

2019-05-05 Thread Denton Liu
Currently, format-patch only accepts branch..description as a branch-specific configuration variable. However, there are many other options which would be useful to have on a branch-by-branch basis, namely cover letter subject and To: and Cc: headers. Teach format-patch to recognise these branch-s