Re: [PATCH 0/7] fix checking out a being-rebased branch

2016-04-19 Thread Junio C Hamano
Duy Nguyen writes: > On Tue, Apr 19, 2016 at 12:42 AM, Junio C Hamano wrote: >>> Another option is leave wt_status_get_state() alone, factor out the >>> rebase-detection code and use that for worktree/checkout. We save a >>> few syscalls this way too. >>> >>> Comments? >>> >>> [01/07] path.c:

Re: [PATCH 0/7] fix checking out a being-rebased branch

2016-04-18 Thread Duy Nguyen
On Tue, Apr 19, 2016 at 12:42 AM, Junio C Hamano wrote: >> Another option is leave wt_status_get_state() alone, factor out the >> rebase-detection code and use that for worktree/checkout. We save a >> few syscalls this way too. >> >> Comments? >> >> [01/07] path.c: add git_common_path() and strb

Re: [PATCH 0/7] fix checking out a being-rebased branch

2016-04-18 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > First cut. I need opinions on 05/07, which converts > wt_status_get_state() to support selecting any worktree. I'm not super > happy with leaving "TODO: not supported yet" comments, even though > strictly speaking this series does not need it. It is a reasonable i

[PATCH 0/7] fix checking out a being-rebased branch

2016-04-17 Thread Nguyễn Thái Ngọc Duy
First cut. I need opinions on 05/07, which converts wt_status_get_state() to support selecting any worktree. I'm not super happy with leaving "TODO: not supported yet" comments, even though strictly speaking this series does not need it. The reason it's left unsupported is, in order to add worktre