Re: [PATCH 0/7] Rewrite `git_config()` using config-set API

2014-07-24 Thread Junio C Hamano
Matthieu Moy writes: > As a side effect, I guess Junio will apply this on top of master so the > string interning API will be available immediately at the tip of the > branch. Thanks for a heads-up. The two-patch series does not use the interning, but does use string_list_init(), which is recen

Re: [PATCH 0/7] Rewrite `git_config()` using config-set API

2014-07-24 Thread Matthieu Moy
Tanay Abhra writes: > On 7/24/2014 9:09 PM, Matthieu Moy wrote: >> Tanay Abhra writes: >> >>> I am attaching the v12 with two new functions git_configset_get_string() & >>> git_configset_get_string_const(). >> >> Didn't you intend to change git_config_get_string to let it die in case >> of err

Re: [PATCH 0/7] Rewrite `git_config()` using config-set API

2014-07-24 Thread Tanay Abhra
On 7/24/2014 9:09 PM, Matthieu Moy wrote: > Tanay Abhra writes: > >> I am attaching the v12 with two new functions git_configset_get_string() & >> git_configset_get_string_const(). > > Didn't you intend to change git_config_get_string to let it die in case > of error instead of returning an er

Re: [PATCH 0/7] Rewrite `git_config()` using config-set API

2014-07-24 Thread Matthieu Moy
Tanay Abhra writes: > I am attaching the v12 with two new functions git_configset_get_string() & > git_configset_get_string_const(). Didn't you intend to change git_config_get_string to let it die in case of error instead of returning an error code? -- Matthieu Moy http://www-verimag.imag.fr/~

Re: [PATCH 0/7] Rewrite `git_config()` using config-set API

2014-07-24 Thread Tanay Abhra
> > Are you done with the original series, or do you still want to fix > the const-ness issue with the string pointer before working on > follow-up topics like this one? > I am attaching the v12 with two new functions git_configset_get_string() & git_configset_get_string_const(). Diff between v1

Re: [PATCH 0/7] Rewrite `git_config()` using config-set API

2014-07-23 Thread Junio C Hamano
Tanay Abhra writes: > This series builds on the top of 5def4132 (ta/config-set) in pu or topic[1] > in the mailing list with name "git config cache & special querying API > utilizing > the cache". > > This series aims to do these three things, > > * Use the config-set API to rewrite git_config()

Re: [PATCH 0/7] Rewrite `git_config()` using config-set API

2014-07-23 Thread Matthieu Moy
Tanay Abhra writes: > This series builds on the top of 5def4132 (ta/config-set) in pu or > topic[1] Not exactly: 5def4132 has been replaced in pu, and it does not contain tests, hence PATCH 3 does not apply on top of 5def4132. The series applies to 0912a24, but does not compile, since you use st

[PATCH 0/7] Rewrite `git_config()` using config-set API

2014-07-23 Thread Tanay Abhra
This series builds on the top of 5def4132 (ta/config-set) in pu or topic[1] in the mailing list with name "git config cache & special querying API utilizing the cache". This series aims to do these three things, * Use the config-set API to rewrite git_config(). * Solve any legacy bugs in the pre