Re: [PATCH 0/6] easy bulk commit creation in tests

2019-06-29 Thread Jeff King
On Sat, Jun 29, 2019 at 10:38:43AM -0600, Elijah Newren wrote: > > - add a feature to fast-import to say "build on top of ref X", instead > > of using to use rev-parse to manually generates a "reset" line > > (maybe this is even possible already; I searched for it, but not > > very h

Re: [PATCH 0/6] easy bulk commit creation in tests

2019-06-29 Thread Elijah Newren
On Fri, Jun 28, 2019 at 6:32 PM Jeff King wrote: > > On Fri, Jun 28, 2019 at 02:53:26PM +0200, Johannes Schindelin wrote: > > > > > It would be nice if we had a "test_commits_bulk" that used fast-import > > > > to create larger numbers of commits. > > > > > > So here's a patch to do that. > > > >

Re: [PATCH 0/6] easy bulk commit creation in tests

2019-06-28 Thread Jeff King
On Fri, Jun 28, 2019 at 08:49:30PM +0200, Ævar Arnfjörð Bjarmason wrote: > > So here's a patch to do that. Writing the bulk commit function was a fun > > exercise, and I found a couple other places to apply it, too, shaving > > off ~7.5 seconds from my test runs. Not ground-breaking, but I think >

Re: [PATCH 0/6] easy bulk commit creation in tests

2019-06-28 Thread Jeff King
On Fri, Jun 28, 2019 at 02:53:26PM +0200, Johannes Schindelin wrote: > > > It would be nice if we had a "test_commits_bulk" that used fast-import > > > to create larger numbers of commits. > > > > So here's a patch to do that. > > I like the direction, especially because it would make it super ea

Re: [PATCH 0/6] easy bulk commit creation in tests

2019-06-28 Thread Ævar Arnfjörð Bjarmason
On Fri, Jun 28 2019, Jeff King wrote: > On Fri, Jun 28, 2019 at 02:41:03AM -0400, Jeff King wrote: > >> I think this would exercise it, at the cost of making the test more >> expensive: >> >> diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh >> index 82d7f7f6a5..8ed6982dcb 100755 >>

Re: [PATCH 0/6] easy bulk commit creation in tests

2019-06-28 Thread Johannes Schindelin
Hi Peff, On Fri, 28 Jun 2019, Jeff King wrote: > On Fri, Jun 28, 2019 at 02:41:03AM -0400, Jeff King wrote: > > > It would be nice if we had a "test_commits_bulk" that used fast-import > > to create larger numbers of commits. > > So here's a patch to do that. I like the direction, especially bec

[PATCH 0/6] easy bulk commit creation in tests

2019-06-28 Thread Jeff King
On Fri, Jun 28, 2019 at 02:41:03AM -0400, Jeff King wrote: > I think this would exercise it, at the cost of making the test more > expensive: > > diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh > index 82d7f7f6a5..8ed6982dcb 100755 > --- a/t/t5310-pack-bitmaps.sh > +++ b/t/t5310-pa