Re: [PATCH 0/6] Kill the_repository in tree-walk.c

2019-06-27 Thread Derrick Stolee
On 6/27/2019 9:04 AM, Johannes Schindelin wrote: > Given that this bug was only caught by a failing CI build, it does make me > wonder what other bugs are hidden and would slip into our code base just > because of gaps in the code coverage. Here are the lines introduced by this series that are not

Re: [PATCH 0/6] Kill the_repository in tree-walk.c

2019-06-27 Thread Johannes Schindelin
Hi Junio, On Wed, 26 Jun 2019, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > > > This is the continuation of nd/sha1-name-c-wo-the-repository. In that > > series I sealed off one place in sha1-name.c that cannot walk trees > > from arbitrary repositories. With tree-walk.c taking 'struc

Re: [PATCH 0/6] Kill the_repository in tree-walk.c

2019-06-26 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > This is the continuation of nd/sha1-name-c-wo-the-repository. In that > series I sealed off one place in sha1-name.c that cannot walk trees > from arbitrary repositories. With tree-walk.c taking 'struct > repository *' directly, that check in there can now be remov

[PATCH 0/6] Kill the_repository in tree-walk.c

2019-06-24 Thread Nguyễn Thái Ngọc Duy
This is the continuation of nd/sha1-name-c-wo-the-repository. In that series I sealed off one place in sha1-name.c that cannot walk trees from arbitrary repositories. With tree-walk.c taking 'struct repository *' directly, that check in there can now be removed. Nguyễn Thái Ngọc Duy (6): sha1-fi