Re: [PATCH 0/5] fix deadlock in git-push

2016-04-20 Thread Jeff King
On Wed, Apr 20, 2016 at 02:17:16PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > The first patch below fixes the deadlock. Unfortunately, it turns it > > into a likely SIGPIPE death. Which is an improvement, but not ideal. > > > > Patches 2 and 3 address that by fixing the way we handle

Re: [PATCH 0/5] fix deadlock in git-push

2016-04-20 Thread Junio C Hamano
Jeff King writes: > The first patch below fixes the deadlock. Unfortunately, it turns it > into a likely SIGPIPE death. Which is an improvement, but not ideal. > > Patches 2 and 3 address that by fixing the way we handle SIGPIPE in > async threads. > > Patches 4 and 5 are cleanups to earlier topi

[PATCH 0/5] fix deadlock in git-push

2016-04-19 Thread Jeff King
I ran across a deadlock today while pushing from a corrupted repository where pack-objects fails. Obviously I don't expect this to succeed, but it should not hang indefinitely. The first patch below fixes the deadlock. Unfortunately, it turns it into a likely SIGPIPE death. Which is an improvement