Re: [PATCH 0/5] consistent setup code for external commands

2016-07-06 Thread Johannes Schindelin
Hi Junio, On Wed, 6 Jul 2016, Junio C Hamano wrote: > I think that amounts to the following single patch, which I cherry > picked from the topic in Dscho's repository he mentioned earlier. That patch would be fine by me, too. Thanks, Dscho -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH 0/5] consistent setup code for external commands

2016-07-06 Thread Junio C Hamano
Jeff King writes: > On Fri, Jul 01, 2016 at 03:19:37PM -0700, Junio C Hamano wrote: > >> > Here they are: >> > >> > [1/5]: add an extra level of indirection to main() >> > [2/5]: common-main: call git_extract_argv0_path() >> > [3/5]: common-main: call sanitize_stdfds() >> > [4/5]: common-

Re: [PATCH 0/5] consistent setup code for external commands

2016-07-01 Thread Jeff King
On Fri, Jul 01, 2016 at 03:19:37PM -0700, Junio C Hamano wrote: > > Here they are: > > > > [1/5]: add an extra level of indirection to main() > > [2/5]: common-main: call git_extract_argv0_path() > > [3/5]: common-main: call sanitize_stdfds() > > [4/5]: common-main: call restore_sigpipe_to

Re: [PATCH 0/5] consistent setup code for external commands

2016-07-01 Thread Junio C Hamano
Jeff King writes: > On Fri, Jul 01, 2016 at 12:07:15AM -0400, Jeff King wrote: > >> Interesting. It's failing on the assert(argv0_path) in system_path(). >> >> That's part of the RUNTIME_PREFIX code which is built only on Windows, >> so this is a Windows-specific issue. >> >> I can guess the re

Re: [PATCH 0/5] consistent setup code for external commands

2016-07-01 Thread Johannes Schindelin
Hi Peff, On Fri, 1 Jul 2016, Jeff King wrote: > - for external programs run as "git foo", you get _two_ times. I considered doing this in my work-around, but decided against it because I deemed it too inelegant to call it twice. But your patch series has more benefits than just fixing the ass

[PATCH 0/5] consistent setup code for external commands

2016-06-30 Thread Jeff King
On Fri, Jul 01, 2016 at 12:07:15AM -0400, Jeff King wrote: > Interesting. It's failing on the assert(argv0_path) in system_path(). > > That's part of the RUNTIME_PREFIX code which is built only on Windows, > so this is a Windows-specific issue. > > I can guess the reason that argv0_path is not s