Re: [PATCH 0/5] Multiple hook support

2019-04-30 Thread Jeff King
On Wed, Apr 24, 2019 at 12:49:43AM +, brian m. carlson wrote: > I've talked with some people about this approach, and they've indicated > they would prefer a configuration-based approach. I think I'm some people. :) I agree with the thoughts that Jonathan pointed out in [1], but I wanted to

Re: [PATCH 0/5] Multiple hook support

2019-04-24 Thread Duy Nguyen
On Thu, Apr 25, 2019 at 6:41 AM brian m. carlson wrote: > > On Wed, Apr 24, 2019 at 04:49:54PM +0700, Duy Nguyen wrote: > > Heh you beat me to it. My config-hooks branch [1] has not been updated > > for half a year. I only skimmed through quickly so no useful comments, > > but I went with a slight

Re: [PATCH 0/5] Multiple hook support

2019-04-24 Thread brian m. carlson
On Wed, Apr 24, 2019 at 04:49:54PM +0700, Duy Nguyen wrote: > Heh you beat me to it. My config-hooks branch [1] has not been updated > for half a year. I only skimmed through quickly so no useful comments, > but I went with a slightly different design, introducing > for_each_hook() instead (see run

Re: [PATCH 0/5] Multiple hook support

2019-04-24 Thread Jonathan Nieder
Hi, brian m. carlson wrote: > On Tue, Apr 23, 2019 at 07:34:38PM -0700, Jonathan Nieder wrote: >> brian m. carlson wrote: >>> I've talked with some people about this approach, and they've indicated >>> they would prefer a configuration-based approach. >> >> I would, too, mostly because that reduc

Re: [PATCH 0/5] Multiple hook support

2019-04-24 Thread brian m. carlson
On Tue, Apr 23, 2019 at 07:34:38PM -0700, Jonathan Nieder wrote: > Hi, > > brian m. carlson wrote: > > > I've talked with some people about this approach, and they've indicated > > they would prefer a configuration-based approach. > > I would, too, mostly because that reduces the problem of secu

Re: [PATCH 0/5] Multiple hook support

2019-04-24 Thread brian m. carlson
On Wed, Apr 24, 2019 at 04:49:54PM +0700, Duy Nguyen wrote: > Heh you beat me to it. My config-hooks branch [1] has not been updated > for half a year. I only skimmed through quickly so no useful comments, > but I went with a slightly different design, introducing > for_each_hook() instead (see run

Re: [PATCH 0/5] Multiple hook support

2019-04-24 Thread Bryan Turner
On Wed, Apr 24, 2019 at 1:10 AM Ævar Arnfjörð Bjarmason wrote: > > On Wed, Apr 24 2019, brian m. carlson wrote: > > > Oftentimes, people want to use multiple of the same kind of hook. This > > may be because software or a project they use requires a given hook, but > > they would also like to have

Re: [PATCH 0/5] Multiple hook support

2019-04-24 Thread Phillip Wood
On 24/04/2019 09:10, Ævar Arnfjörð Bjarmason wrote: > > On Wed, Apr 24 2019, brian m. carlson wrote: > >> Oftentimes, people want to use multiple of the same kind of hook. This >> may be because software or a project they use requires a given hook, but >> they would also like to have a custom hoo

Re: [PATCH 0/5] Multiple hook support

2019-04-24 Thread Duy Nguyen
On Wed, Apr 24, 2019 at 7:54 AM brian m. carlson wrote: > > Oftentimes, people want to use multiple of the same kind of hook. This > may be because software or a project they use requires a given hook, but > they would also like to have a custom hook, or because they're using > multiple pieces of

Re: [PATCH 0/5] Multiple hook support

2019-04-24 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 24 2019, Jonathan Nieder wrote: > Hi, > > brian m. carlson wrote: > >> I've talked with some people about this approach, and they've indicated >> they would prefer a configuration-based approach. > > I would, too, mostly because that reduces the problem of securing > hooks to securin

Re: [PATCH 0/5] Multiple hook support

2019-04-24 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 24 2019, brian m. carlson wrote: > On Wed, Apr 24, 2019 at 11:09:10AM +0900, Junio C Hamano wrote: >> "brian m. carlson" writes: >> >> > To preserve backwards compatibility, we don't run the hooks in the ".d" >> > directory if the single file is a valid hook (i.e. it exists and is >

Re: [PATCH 0/5] Multiple hook support

2019-04-24 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 24 2019, brian m. carlson wrote: > Oftentimes, people want to use multiple of the same kind of hook. This > may be because software or a project they use requires a given hook, but > they would also like to have a custom hook, or because they're using > multiple pieces of software th

Re: [PATCH 0/5] Multiple hook support

2019-04-24 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 24 2019, Jonathan Nieder wrote: > brian m. carlson wrote: brian: I'm very interested in this. I barked up this tree before almost exactly 3 years ago: https://public-inbox.org/git/cacbzzx6j6q2dun_z-pnent1u714dvnpfbrl_pieqylmczlu...@mail.gmail.com/ https://public-inbox.org

Re: [PATCH 0/5] Multiple hook support

2019-04-23 Thread Junio C Hamano
"brian m. carlson" writes: > On Wed, Apr 24, 2019 at 11:09:10AM +0900, Junio C Hamano wrote: >> "brian m. carlson" writes: >> >> > To preserve backwards compatibility, we don't run the hooks in the ".d" >> > directory if the single file is a valid hook (i.e. it exists and is >> > executable). T

Re: [PATCH 0/5] Multiple hook support

2019-04-23 Thread Jonathan Nieder
Hi, brian m. carlson wrote: > I've talked with some people about this approach, and they've indicated > they would prefer a configuration-based approach. I would, too, mostly because that reduces the problem of securing hooks to securing configuration. See https://public-inbox.org/git/201710022

Re: [PATCH 0/5] Multiple hook support

2019-04-23 Thread brian m. carlson
On Wed, Apr 24, 2019 at 11:09:10AM +0900, Junio C Hamano wrote: > "brian m. carlson" writes: > > > To preserve backwards compatibility, we don't run the hooks in the ".d" > > directory if the single file is a valid hook (i.e. it exists and is > > executable). This is because some people already h

Re: [PATCH 0/5] Multiple hook support

2019-04-23 Thread Junio C Hamano
"brian m. carlson" writes: > To preserve backwards compatibility, we don't run the hooks in the ".d" > directory if the single file is a valid hook (i.e. it exists and is > executable). This is because some people already have multiple hook > scripts configured, and if we ran them both, we'd run

[PATCH 0/5] Multiple hook support

2019-04-23 Thread brian m. carlson
Oftentimes, people want to use multiple of the same kind of hook. This may be because software or a project they use requires a given hook, but they would also like to have a custom hook, or because they're using multiple pieces of software that both require involvement with the same hook. This se