Re: [PATCH 0/4] nd/ita-empty-commit update

2016-10-25 Thread Duy Nguyen
On Tue, Oct 25, 2016 at 12:58 AM, Junio C Hamano wrote: >> The name ita-invisible-in-index is not perfect but I could not think >> of any better. Another name could be diff-cached-ignores-ita, but >> that's just half of what it does. The other half is >> diff-files-includes-ita... > > I can't eit

Re: [PATCH 0/4] nd/ita-empty-commit update

2016-10-24 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > The index_differs_from() also takes a flag to set/clear this new > flag instead of relying on has_ita_entries like the old 2/3. I think that probably is a good move. > The name ita-invisible-in-index is not perfect but I could not think > of any better. Another n

[PATCH 0/4] nd/ita-empty-commit update

2016-10-24 Thread Nguyễn Thái Ngọc Duy
This version splits the old 1/3 into two, with better description in 1/4. The index_differs_from() also takes a flag to set/clear this new flag instead of relying on has_ita_entries like the old 2/3. The name ita-invisible-in-index is not perfect but I could not think of any better. Another name c