Re: [PATCH 0/3] protocol v2 and hidden refs

2018-12-16 Thread Ævar Arnfjörð Bjarmason
On Sun, Dec 16 2018, Jeff King wrote: > On Sat, Dec 15, 2018 at 08:53:35PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> > So I'm a bit worried that the unified endpoint model is going to be a >> > dead end, at which point carrying around git-serve just makes things >> > more complicated. >> >> Thi

Re: [PATCH 0/3] protocol v2 and hidden refs

2018-12-16 Thread Jeff King
On Sat, Dec 15, 2018 at 08:53:35PM +0100, Ævar Arnfjörð Bjarmason wrote: > > So I'm a bit worried that the unified endpoint model is going to be a > > dead end, at which point carrying around git-serve just makes things > > more complicated. > > This is from wetware memory of something discussed

Re: [PATCH 0/3] protocol v2 and hidden refs

2018-12-15 Thread Ævar Arnfjörð Bjarmason
On Fri, Dec 14 2018, Jeff King wrote: > On Thu, Dec 13, 2018 at 11:53:05AM -0800, Jonathan Tan wrote: > >> > I don't know if there's a good solution. I tried running the whole >> > test suite with v2 as the default. It does find this bug, but it has >> > a bunch of other problems (no

Re: [PATCH 0/3] protocol v2 and hidden refs

2018-12-14 Thread Jeff King
On Thu, Dec 13, 2018 at 11:53:05AM -0800, Jonathan Tan wrote: > > I don't know if there's a good solution. I tried running the whole > > test suite with v2 as the default. It does find this bug, but it has > > a bunch of other problems (notably fetch-pack won't run as v2, but > > s

Re: [PATCH 0/3] protocol v2 and hidden refs

2018-12-13 Thread Jonathan Tan
Just realized that I haven't replied to this yet... > - I'm a little worried this may happen again with future features. The > root cause is that "ls-refs" follows a different code path than the > ref advertisement for "upload-pack". So if we add any new config, > it needs to go both

Re: [PATCH 0/3] protocol v2 and hidden refs

2018-12-11 Thread Jeff King
On Tue, Dec 11, 2018 at 12:45:16PM +0100, Ævar Arnfjörð Bjarmason wrote: > > I don't know if there's a good solution. I tried running the whole > > test suite with v2 as the default. It does find this bug, but it has > > a bunch of other problems (notably fetch-pack won't run as v2, bu

Re: [PATCH 0/3] protocol v2 and hidden refs

2018-12-11 Thread Ævar Arnfjörð Bjarmason
On Tue, Dec 11 2018, Jeff King wrote: > When using the v2 protocol, hidden-ref config is not respected at all: > > $ git config transfer.hiderefs refs/tags/ > $ git -c protocol.version=0 ls-remote . | grep -c refs/tags > 0 > $ git -c protocol.version=2 ls-remote . | grep -c refs/tags >

[PATCH 0/3] protocol v2 and hidden refs

2018-12-11 Thread Jeff King
When using the v2 protocol, hidden-ref config is not respected at all: $ git config transfer.hiderefs refs/tags/ $ git -c protocol.version=0 ls-remote . | grep -c refs/tags 0 $ git -c protocol.version=2 ls-remote . | grep -c refs/tags 1424 The fix in patch 3 is pretty straightforward, b