Re: [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance

2017-11-01 Thread Stefan Beller
> It sounds a bit stupid to cater to myself in patches *I* submit, but I > refuse to believe that there are many people with more time on their hands > than myself (last time I tried to research this, it looked as everybody > has the same 86,400 seconds per day available, give or take the occasiona

Re: [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance

2017-11-01 Thread Johannes Schindelin
Hi Jonahtan, On Tue, 31 Oct 2017, Jonathan Nieder wrote: > Johannes Schindelin wrote: > > On Mon, 30 Oct 2017, Jonathan Nieder wrote: > > >> Can this rationale go in the commit messages? > > > > I thought I had done exactly that in 1/3... > > Okay, I'll be more specific. This cover letter incl

Re: [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance

2017-10-31 Thread Jonathan Nieder
Hi, Johannes Schindelin wrote: > On Mon, 30 Oct 2017, Jonathan Nieder wrote: >> Can this rationale go in the commit messages? > > I thought I had done exactly that in 1/3... Okay, I'll be more specific. This cover letter includes some information about the rationale and motivation for the serie

Re: [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance

2017-10-31 Thread Johannes Schindelin
Hi Jonathan, On Mon, 30 Oct 2017, Jonathan Nieder wrote: > Johannes Schindelin wrote: > > > Particularly when calling Git from applications, such as Visual Studio, > > it is important that stdin/stdout/stderr are closed properly. However, > > when spawning processes on Windows, those handles mus

Re: [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance

2017-10-30 Thread Junio C Hamano
Jonathan Nieder writes: >> This feature was introduced as an experimental feature into Git for >> Windows v2.11.0(2) and has been tested ever since. I feel it is >> well-tested enough that it can be integrated into core Git. > > Can this rationale go in the commit messages? > > Actually I wouldn'

Re: [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance

2017-10-30 Thread Jonathan Nieder
Hi, Johannes Schindelin wrote: > Particularly when calling Git from applications, such as Visual Studio, > it is important that stdin/stdout/stderr are closed properly. However, > when spawning processes on Windows, those handles must be marked as > inheritable if we want to use them, but that fl

[PATCH 0/3] mingw: introduce a way to avoid std handle inheritance

2017-10-30 Thread Johannes Schindelin
Particularly when calling Git from applications, such as Visual Studio, it is important that stdin/stdout/stderr are closed properly. However, when spawning processes on Windows, those handles must be marked as inheritable if we want to use them, but that flag is a global flag and may very well be