Re: [PATCH 0/3] index-helper: fix UNIX_PATH_MAX redefinition error on cygwin

2016-04-11 Thread Jeff King
On Mon, Apr 11, 2016 at 05:29:22PM -0400, David Turner wrote: > On Mon, 2016-04-11 at 09:33 -0400, Jeff King wrote: > > On Sun, Apr 10, 2016 at 11:57:31PM +0100, Ramsay Jones wrote: > > > > > So, the approach taken by patch #1 is to forget about UNIX_PATH_MAX > > > and > > > simply use sizeof(add

Re: [PATCH 0/3] index-helper: fix UNIX_PATH_MAX redefinition error on cygwin

2016-04-11 Thread David Turner
On Mon, 2016-04-11 at 09:33 -0400, Jeff King wrote: > On Sun, Apr 10, 2016 at 11:57:31PM +0100, Ramsay Jones wrote: > > > So, the approach taken by patch #1 is to forget about UNIX_PATH_MAX > > and > > simply use sizeof(address.sun_path) instead! > > That's what the existing code in unix-socket.c

Re: [PATCH 0/3] index-helper: fix UNIX_PATH_MAX redefinition error on cygwin

2016-04-11 Thread Jeff King
On Sun, Apr 10, 2016 at 11:57:31PM +0100, Ramsay Jones wrote: > So, the approach taken by patch #1 is to forget about UNIX_PATH_MAX and > simply use sizeof(address.sun_path) instead! That's what the existing code in unix-socket.c does. Which makes me wonder why the index-helper code is not simply

[PATCH 0/3] index-helper: fix UNIX_PATH_MAX redefinition error on cygwin

2016-04-10 Thread Ramsay Jones
Hi David, Duy, If you need to re-roll your 'dt/index-helper' branch, could you please consider squashing these patches into the relevant patch (equivalent to commit 12909da4 ("index-helper: new daemon for caching index and related stuff", 06-04-2016)). The above commit causes the cygwin build to