Re: [PATCH 0/3] fix diff-parseopt regressions

Duy Nguyen wrote: > On Sat, May 25, 2019 at 12:36 AM Todd Zullinger wrote: >> I applied this on top of master/2.22.0-rc1 and see a number >> of compiler errors using gcc-9.1.1 with fedora's standard >> compiler options for rpm builds. > > That last patch 4/3 is not meant to be applied. Yes I've s

Re: [PATCH 0/3] fix diff-parseopt regressions

On Sat, May 25, 2019 at 12:36 AM Todd Zullinger wrote: > > Hi, > > Nguyễn Thái Ngọc Duy wrote: > > This should fix the diff tests failure on s360x. It's a serious problem > > and I plan to do something to prevent it from happening again. > > Thanks for looking at this! > > I applied this on top of

Re: [PATCH 0/3] fix diff-parseopt regressions

I wrote: > Below are the compiler errors. Well, to be precise, all but imap-send are warnings rather than errors. -- Todd

Re: [PATCH 0/3] fix diff-parseopt regressions

Hi, Nguyễn Thái Ngọc Duy wrote: > This should fix the diff tests failure on s360x. It's a serious problem > and I plan to do something to prevent it from happening again. Thanks for looking at this! I applied this on top of master/2.22.0-rc1 and see a number of compiler errors using gcc-9.1.1 wi

[PATCH 0/3] fix diff-parseopt regressions

This should fix the diff tests failure on s360x. It's a serious problem and I plan to do something to prevent it from happening again. The second patch should bring '-U' (no argument) back. Whether it makes sense to accept this behavior is not part of this conversion. We can deal with that later.