Re: [PATCH 0/3] convert submodule.c to not use the index compat macros

2017-12-12 Thread Junio C Hamano
Brandon Williams writes: > This series removes the remaining users of the index compatibility macros and > ensures that future uses of the macros will result in compiler errors. Nice. Will queue. Thanks.

Re: [PATCH 0/3] convert submodule.c to not use the index compat macros

2017-12-12 Thread Junio C Hamano
Stefan Beller writes: > ... would call out patch 2 to be a bugfix that could > go independently, but the whole series is fine as-is with me. Good eyes. I agree that it makes sense to treat 2/3 as a follow-up fix for an already graduated topic, and make the other two depend on a result of appl

Re: [PATCH 0/3] convert submodule.c to not use the index compat macros

2017-12-12 Thread Stefan Beller
On Tue, Dec 12, 2017 at 11:53 AM, Brandon Williams wrote: > This series removes the remaining users of the index compatibility macros and > ensures that future uses of the macros will result in compiler errors. Thanks for converting the submodule code to avoid these old macros. Specifically the s

[PATCH 0/3] convert submodule.c to not use the index compat macros

2017-12-12 Thread Brandon Williams
This series removes the remaining users of the index compatibility macros and ensures that future uses of the macros will result in compiler errors. Brandon Williams (3): submodule: convert stage_updated_gitmodules to take a struct index_state submodule: used correct index in is_staging_gi