Re: [PATCH 0/3] convert diff flags to be stored in a struct

2017-10-28 Thread Stefan Beller
On Sat, Oct 28, 2017 at 6:22 PM, Junio C Hamano wrote: >> Some thoughts: >> * We may want to do a follow on patch to convert all the flags from being in >>uppercase to lower case. > > If and only if we do not use macros to set/clr/test, this makes a > lot of sense. Otherwise, probably not.

Re: [PATCH 0/3] convert diff flags to be stored in a struct

2017-10-28 Thread Junio C Hamano
Brandon Williams writes: > There has be some desire to add additional flags to the diff machineery > (https://public-inbox.org/git/20171024000931.14814-1-sbel...@google.com/) but > due to the limits of the number of bits in an unsigned int on some systems we > can't add any additonal flags to the

[PATCH 0/3] convert diff flags to be stored in a struct

2017-10-27 Thread Brandon Williams
There has be some desire to add additional flags to the diff machineery (https://public-inbox.org/git/20171024000931.14814-1-sbel...@google.com/) but due to the limits of the number of bits in an unsigned int on some systems we can't add any additonal flags to the 'flags' variable. This series con