Re: [PATCH 0/3] Convert grep to recurse in-process

2017-07-12 Thread Jeff King
On Wed, Jul 12, 2017 at 11:24:47AM -0700, Jonathan Nieder wrote: > Jeff King wrote: > > On Wed, Jul 12, 2017 at 11:06:03AM -0700, Brandon Williams wrote: > > >> Each 'struct repository' does have its own config so we could > >> potentially want a config in a submodule to override some config in t

Re: [PATCH 0/3] Convert grep to recurse in-process

2017-07-12 Thread Jeff King
On Wed, Jul 12, 2017 at 11:09:23AM -0700, Jonathan Nieder wrote: > > I didn't follow the rest of the "struct repository" series closely, but > > I don't feel like we ever reached a resolution on how config would be > > handled. I notice that the in-process "ls-files" behaves differently > > than t

Re: [PATCH 0/3] Convert grep to recurse in-process

2017-07-12 Thread Jonathan Nieder
Jeff King wrote: > On Wed, Jul 12, 2017 at 11:06:03AM -0700, Brandon Williams wrote: >> Each 'struct repository' does have its own config so we could >> potentially want a config in a submodule to override some config in the >> superproject. Though for right now it may be simpler to not worry abo

Re: [PATCH 0/3] Convert grep to recurse in-process

2017-07-12 Thread Jeff King
On Wed, Jul 12, 2017 at 11:06:03AM -0700, Brandon Williams wrote: > > I didn't follow the rest of the "struct repository" series closely, but > > I don't feel like we ever reached a resolution on how config would be > > handled. I notice that the in-process "ls-files" behaves differently > > than

Re: [PATCH 0/3] Convert grep to recurse in-process

2017-07-12 Thread Stefan Beller
On Wed, Jul 12, 2017 at 11:09 AM, Jonathan Nieder wrote: > Hi, > > Jeff King wrote: > >> I didn't follow the rest of the "struct repository" series closely, but >> I don't feel like we ever reached a resolution on how config would be >> handled. I notice that the in-process "ls-files" behaves diff

Re: [PATCH 0/3] Convert grep to recurse in-process

2017-07-12 Thread Jonathan Nieder
Hi, Jeff King wrote: > I didn't follow the rest of the "struct repository" series closely, but > I don't feel like we ever reached a resolution on how config would be > handled. I notice that the in-process "ls-files" behaves differently > than the old one when config differs between the submodul

Re: [PATCH 0/3] Convert grep to recurse in-process

2017-07-12 Thread Brandon Williams
On 07/12, Jeff King wrote: > On Tue, Jul 11, 2017 at 03:04:05PM -0700, Brandon Williams wrote: > > > This series utilizes the new 'struct repository' in order to convert grep > > to be > > able to recurse into submodules in-process much like how ls-files was > > converted > > to recuse in-proces

Re: [PATCH 0/3] Convert grep to recurse in-process

2017-07-12 Thread Jeff King
On Tue, Jul 11, 2017 at 03:04:05PM -0700, Brandon Williams wrote: > This series utilizes the new 'struct repository' in order to convert grep to > be > able to recurse into submodules in-process much like how ls-files was > converted > to recuse in-process. The result is a much smaller code foo

[PATCH 0/3] Convert grep to recurse in-process

2017-07-11 Thread Brandon Williams
This series utilizes the new 'struct repository' in order to convert grep to be able to recurse into submodules in-process much like how ls-files was converted to recuse in-process. The result is a much smaller code footprint due to not needing to compile an argv array of options to be used when l