Re: [PATCH 0/3] Close commit-graph before calling 'gc'

2019-05-20 Thread Derrick Stolee
On 5/18/2019 10:04 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > >> This series adds close_commit_graph() to close_all_packs() and then renames >> close_all_packs() to close_object_store(). This name is more descriptive of >> its larger purpose. > > OK. Somebody needs

Re: [PATCH 0/3] Close commit-graph before calling 'gc'

2019-05-20 Thread Johannes Schindelin
Hi Junio, On Sun, 19 May 2019, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > > > This series adds close_commit_graph() to close_all_packs() and then renames > > close_all_packs() to close_object_store(). This name is more descriptive of > > its larger purpose. > > OK. Some

Re: [PATCH 0/3] Close commit-graph before calling 'gc'

2019-05-20 Thread Johannes Schindelin
Hi Stolee, On Fri, 17 May 2019, Derrick Stolee via GitGitGadget wrote: > In Windows, the way we rename a lock file to replace the underlying file > does not work when a process holds a read handle. For this reason, we call > close_all_packs() everywhere before starting a git gc --auto subprocess.

Re: [PATCH 0/3] Close commit-graph before calling 'gc'

2019-05-18 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > This series adds close_commit_graph() to close_all_packs() and then renames > close_all_packs() to close_object_store(). This name is more descriptive of > its larger purpose. OK. Somebody needs to go though all the existing callers of close_all_pack

[PATCH 0/3] Close commit-graph before calling 'gc'

2019-05-17 Thread Derrick Stolee via GitGitGadget
In Windows, the way we rename a lock file to replace the underlying file does not work when a process holds a read handle. For this reason, we call close_all_packs() everywhere before starting a git gc --auto subprocess. We also call close_commit_graph() before renaming the commit-graph lock file.