Re: [PATCH 0/2] pre-commit hook updates

2014-11-26 Thread Jeff King
On Wed, Nov 26, 2014 at 10:35:22AM -0800, Junio C Hamano wrote: > I _think_ "give only info that is necessary" is cleaner as an > interface in theory, but have two niggles myself: > > 1. the hooks must do the "argument parsing" loop (you already > mentioned this); > > 2. the hooks cannot t

Re: [PATCH 0/2] pre-commit hook updates

2014-11-26 Thread Junio C Hamano
Jeff King writes: > On Tue, Nov 25, 2014 at 11:51:27PM +0100, Øystein Walle wrote: > >> I agree with Junio Hamano that it's better to provide no argument at all >> rather than an empty one. I also agree with Jeff King that "noamend" is >> better than an empty argument. I went with the second one

Re: [PATCH 0/2] pre-commit hook updates

2014-11-25 Thread Jeff King
On Tue, Nov 25, 2014 at 11:51:27PM +0100, Øystein Walle wrote: > I agree with Junio Hamano that it's better to provide no argument at all > rather than an empty one. I also agree with Jeff King that "noamend" is > better than an empty argument. I went with the second one since Jeff > seemed to get

Re: [PATCH 0/2] pre-commit hook updates

2014-11-25 Thread Eric Sunshine
On Tue, Nov 25, 2014 at 5:51 PM, Øystein Walle wrote: > The first patch changes t/t7503-pre-commit-hook.sh to use write_script > everywhere, as was suggested by Jeff King in the discussion of the > previous patch. > > The second patch is v2 of the patch I sent earlier. I've incorporated > Eric Sun

[PATCH 0/2] pre-commit hook updates

2014-11-25 Thread Øystein Walle
The first patch changes t/t7503-pre-commit-hook.sh to use write_script everywhere, as was suggested by Jeff King in the discussion of the previous patch. The second patch is v2 of the patch I sent earlier. I've incorporated Eric Sunshine's suggestions. I didn't do enough digging; I found test_expe