Re: [PATCH 0/2] git-p4: Improve client path detection

2015-04-18 Thread Vitor Antunes
Hi Junio, Junio C Hamano wrote on Sun, 12 Apr 2015 20:40:58 -0700 > Vitor Antunes writes: >> Luke Diamand wrote on Sun, 05 Apr 2015 20:27:11 +0100 >>> Vitor, one thing I wondered about with this part of the change: >>> >>> -if entry["depotFile"] == depotPath: >>> +if ent

Re: [PATCH 0/2] git-p4: Improve client path detection

2015-04-12 Thread Junio C Hamano
Vitor Antunes writes: > Luke Diamand wrote on Sun, 05 Apr 2015 20:27:11 +0100 >> On 28/03/15 12:28, Vitor Antunes wrote: >> > I'm adding a test case for a scenario I was confronted with when using >> > branch >> > detection and a client view specification. It is possible that the >> > implemen

Re: [PATCH 0/2] git-p4: Improve client path detection

2015-04-05 Thread Vitor Antunes
Luke Diamand wrote on Sun, 05 Apr 2015 20:27:11 +0100 > On 28/03/15 12:28, Vitor Antunes wrote: > > I'm adding a test case for a scenario I was confronted with when using > > branch > > detection and a client view specification. It is possible that the > > implemented > > fix may not cover all p

Re: [PATCH 0/2] git-p4: Improve client path detection

2015-04-05 Thread Luke Diamand
On 28/03/15 12:28, Vitor Antunes wrote: I'm adding a test case for a scenario I was confronted with when using branch detection and a client view specification. It is possible that the implemented fix may not cover all possible scenarios, but there is no regression in the available tests. Vitor

[PATCH 0/2] git-p4: Improve client path detection

2015-03-28 Thread Vitor Antunes
I'm adding a test case for a scenario I was confronted with when using branch detection and a client view specification. It is possible that the implemented fix may not cover all possible scenarios, but there is no regression in the available tests. Vitor Antunes (2): git-p4: Check branch detect