Re: [PATCH 0/1] diff: release all handles before running external diff

2019-07-08 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > On Windows, it is not possible to overwrite a file as long as any process > holds a read handle to it. Even keeping regions memory-mapped prevents that. That second sentence was quite helpful, as I do recall us closing after mmapping. Without it,

[PATCH 0/1] diff: release all handles before running external diff

2019-07-04 Thread Johannes Schindelin via GitGitGadget
On Windows, it is not possible to overwrite a file as long as any process holds a read handle to it. Even keeping regions memory-mapped prevents that. When git difftool calls git diff, it might be the user's intention to write the file(s) via the diff tool, so let's make sure that they are not mem