Re: [PATCH 0/1] Makefile: fix the "built from commit" code

2018-06-28 Thread brian m. carlson
On Thu, Jun 28, 2018 at 12:53:15PM +, Johannes Schindelin via GitGitGadget wrote: > Let's fix that quoting, and while at it, also suppress the unhelpful > message > > fatal: not a git repository (or any of the parent directories): .git > > that gets printed to stderr if no current commit cou

Re: [PATCH 0/1] Makefile: fix the "built from commit" code

2018-06-28 Thread Johannes Schindelin
Team, [Cc:ing Tim] On Thu, 28 Jun 2018, Johannes Schindelin via GitGitGadget wrote: > In ed32b788c06 (version --build-options: report commit, too, if > possible, 2017-12-15), we introduced code to let `git version > --build-options` report the current commit from which the binaries were > built,

[PATCH 0/1] Makefile: fix the "built from commit" code

2018-06-28 Thread Johannes Schindelin via GitGitGadget
In ed32b788c06 (version --build-options: report commit, too, if possible, 2017-12-15), we introduced code to let `git version --build-options` report the current commit from which the binaries were built, if any. To prevent erroneous commits from being reported (e.g. when unpacking Git's source co