Re: [PATCH 0/1] Colorize some errors on stderr

2018-04-06 Thread Ævar Arnfjörð Bjarmason
On Fri, Feb 16 2018, Johannes Schindelin wrote: > This is an RFC because it tries to introduce a fundamental new color feature: > Coloring messages *on stderr*. I missed this the first time around, and don't have anything to add that others haven't covered. Just wanted to say I'd love to get thi

Re: [PATCH 0/1] Colorize some errors on stderr

2018-04-06 Thread Johannes Schindelin
Hi Junio, [and welcome back, at least I hope you only read this after a good and relaxing vacation] On Fri, 16 Feb 2018, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Now, what would be possible solutions for this? > > > > - introduce `int fd` in `want_color()` (and callees) so tha

Re: [PATCH 0/1] Colorize some errors on stderr

2018-02-16 Thread Junio C Hamano
Johannes Schindelin writes: > Now, what would be possible solutions for this? > > - introduce `int fd` in `want_color()` (and callees) so that we can make > a distinction whether we want to detect whether stdout or stderr is > connected > to a tty > > - introduce a separate `want_color_stder

[PATCH 0/1] Colorize some errors on stderr

2018-02-16 Thread Johannes Schindelin
This is an RFC because it tries to introduce a fundamental new color feature: Coloring messages *on stderr*. So far, pretty much everything in color.[ch] assumed that you want to color only stuff on stdout. However, in this case, a user (who became a contributor!) wanted some messages that are pr