Re: [PATCH (Apple Git) 02/13] test-lib: Export PERL5LIB for testing git-svn

2019-01-30 Thread Junio C Hamano
Jeremy Sequoia writes: >> On Jan 29, 2019, at 15:59, SZEDER Gábor wrote: >> >>> On Tue, Jan 29, 2019 at 03:46:07PM -0800, Jeremy Huddleston Sequoia wrote: >>> >>> On Jan 29, 2019, at 2:47 PM, Junio C Hamano wrote: This obviously won't be acceptable as-is to my tree. Shouldn'

Re: [PATCH (Apple Git) 02/13] test-lib: Export PERL5LIB for testing git-svn

2019-01-30 Thread Jeremy Sequoia
Sent from my iPhone... > On Jan 30, 2019, at 04:51, Johannes Schindelin > wrote: > > Hi Jeremy, > > On Tue, 29 Jan 2019, Jeremy Huddleston Sequoia wrote: > >>> On Jan 29, 2019, at 2:47 PM, Junio C Hamano wrote: >>> >>> Jeremy Huddleston Sequoia writes: >>> Signed-off-by: Jeremy Hu

Re: [PATCH (Apple Git) 02/13] test-lib: Export PERL5LIB for testing git-svn

2019-01-30 Thread Johannes Schindelin
Hi Jeremy, On Tue, 29 Jan 2019, Jeremy Huddleston Sequoia wrote: > > On Jan 29, 2019, at 2:47 PM, Junio C Hamano wrote: > > > > Jeremy Huddleston Sequoia writes: > > > >> Signed-off-by: Jeremy Huddleston Sequoia > >> --- > >> t/test-lib.sh | 3 +++ > >> 1 file changed, 3 insertions(+) > > >

Re: [PATCH (Apple Git) 02/13] test-lib: Export PERL5LIB for testing git-svn

2019-01-29 Thread Carlo Arenas
/usr/local/versioner/perl/versions is also not provided with macOS or Xcode AFAIK Carlo

Re: [PATCH (Apple Git) 02/13] test-lib: Export PERL5LIB for testing git-svn

2019-01-29 Thread Jeremy Sequoia
Sent from my iPhone... > On Jan 29, 2019, at 15:59, SZEDER Gábor wrote: > >> On Tue, Jan 29, 2019 at 03:46:07PM -0800, Jeremy Huddleston Sequoia wrote: >> >> >>> On Jan 29, 2019, at 2:47 PM, Junio C Hamano wrote: >>> >>> Jeremy Huddleston Sequoia writes: >>> Signed-off-by: Jeremy H

Re: [PATCH (Apple Git) 02/13] test-lib: Export PERL5LIB for testing git-svn

2019-01-29 Thread SZEDER Gábor
On Tue, Jan 29, 2019 at 03:46:07PM -0800, Jeremy Huddleston Sequoia wrote: > > > > On Jan 29, 2019, at 2:47 PM, Junio C Hamano wrote: > > > > Jeremy Huddleston Sequoia writes: > > > >> Signed-off-by: Jeremy Huddleston Sequoia > >> --- > >> t/test-lib.sh | 3 +++ > >> 1 file changed, 3 inserti

Re: [PATCH (Apple Git) 02/13] test-lib: Export PERL5LIB for testing git-svn

2019-01-29 Thread Jeremy Huddleston Sequoia
> On Jan 29, 2019, at 2:47 PM, Junio C Hamano wrote: > > Jeremy Huddleston Sequoia writes: > >> Signed-off-by: Jeremy Huddleston Sequoia >> --- >> t/test-lib.sh | 3 +++ >> 1 file changed, 3 insertions(+) > > This obviously won't be acceptable as-is to my tree. Shouldn't this > be somethin

Re: [PATCH (Apple Git) 02/13] test-lib: Export PERL5LIB for testing git-svn

2019-01-29 Thread Junio C Hamano
Jeremy Huddleston Sequoia writes: > Signed-off-by: Jeremy Huddleston Sequoia > --- > t/test-lib.sh | 3 +++ > 1 file changed, 3 insertions(+) This obviously won't be acceptable as-is to my tree. Shouldn't this be something to be dealt with in config.mak.uname or something that is meant to def

[PATCH (Apple Git) 02/13] test-lib: Export PERL5LIB for testing git-svn

2019-01-29 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia --- t/test-lib.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t/test-lib.sh b/t/test-lib.sh index 0f1faa24b2..4060a53f56 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -1017,6 +1017,9 @@ fi GITPERLLIB="$GIT_BUILD_DIR"/perl/build/lib expor