Re: [PATCH] xdiff: avoid accidental redefinition of LFS feature in OpenIndiana

2019-06-18 Thread Johannes Schindelin
Hi Carlo, in the Git ecosystem, the abbreviation "LFS" does not mean what you think it means... Let's not use the abbreviation for anything else. On Mon, 17 Jun 2019, Carlo Marcelo Arenas Belón wrote: > after b46054b374 ("xdiff: use git-compat-util", 2019-04-11), two system > headers added in 20

[PATCH] xdiff: avoid accidental redefinition of LFS feature in OpenIndiana

2019-06-17 Thread Carlo Marcelo Arenas Belón
after b46054b374 ("xdiff: use git-compat-util", 2019-04-11), two system headers added in 2012 to xutils where no longer needed and could conflict as shown below: In file included from xdiff/xinclude.h:26:0, from xdiff/xutils.c:25: ./git-compat-util.h:4:0: warning: "_FILE_OFFSET_BI