Re: [PATCH] worktree: initialize return value for submodule_uses_worktrees

2016-12-27 Thread Junio C Hamano
Stefan Beller writes: > On Tue, Dec 27, 2016 at 2:12 PM, Junio C Hamano wrote: > >> I'm planning to disappear until early next >> year > > Safe travels! Thanks. > I assume there is no interim maintainer for such a short > period of time (which also is not as busy). I plan to take my Flip with

Re: [PATCH] worktree: initialize return value for submodule_uses_worktrees

2016-12-27 Thread Stefan Beller
On Tue, Dec 27, 2016 at 2:12 PM, Junio C Hamano wrote: > > or even make it a helper function "is_empty_directory(const char *)". This sounds like the way to go IMHO. > I'm planning to disappear until early next > year Safe travels! I assume there is no interim maintainer for such a short perio

Re: [PATCH] worktree: initialize return value for submodule_uses_worktrees

2016-12-27 Thread Junio C Hamano
Stefan Beller writes: > When the worktrees directory is empty, the `ret` will be returned > uninitialized. Fix it by initializing the value. > > Signed-off-by: Stefan Beller > --- > > This goes on top of 1a248cf (origin/sb/submodule-embed-gitdir); > ideally to be squashed, but as it is in next a

[PATCH] worktree: initialize return value for submodule_uses_worktrees

2016-12-27 Thread Stefan Beller
When the worktrees directory is empty, the `ret` will be returned uninitialized. Fix it by initializing the value. Signed-off-by: Stefan Beller --- This goes on top of 1a248cf (origin/sb/submodule-embed-gitdir); ideally to be squashed, but as it is in next already, as a separate patch. Thanks,