Re: [PATCH] worktree: add: introduce the --name option

2016-07-20 Thread Antoine Tenart
On Wed, Jul 20, 2016 at 04:54:40PM +0200, Duy Nguyen wrote: > On Tue, Jul 19, 2016 at 9:35 PM, Antoine Tenart wrote: > > > > Hmm, so if I understand correctly my use case still won't be supported, > > as adding a new worktree with the same basename will fail. Or did I miss > > something? > > Hm..

Re: [PATCH] worktree: add: introduce the --name option

2016-07-20 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 9:35 PM, Antoine Tenart wrote: > On Tue, Jul 19, 2016 at 09:04:11PM +0200, Duy Nguyen wrote: >> On Tue, Jul 19, 2016 at 8:54 PM, Antoine Tenart >> wrote: >> > On Tue, Jul 19, 2016 at 08:23:58PM +0200, Duy Nguyen wrote: >> >> On Tue, Jul 19, 2016 at 8:04 PM, Junio C Hamano

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Antoine Tenart
Hello Eric, On Tue, Jul 19, 2016 at 02:52:42PM -0400, Eric Sunshine wrote: > On Tue, Jul 19, 2016 at 2:04 PM, Junio C Hamano wrote: > > Antoine Tenart writes: > >> Adds a --name option allowing to specify the name of a worktree when > >> creating it. This allows to have multiple worktrees in dir

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Antoine Tenart
On Tue, Jul 19, 2016 at 09:04:11PM +0200, Duy Nguyen wrote: > On Tue, Jul 19, 2016 at 8:54 PM, Antoine Tenart wrote: > > On Tue, Jul 19, 2016 at 08:23:58PM +0200, Duy Nguyen wrote: > >> On Tue, Jul 19, 2016 at 8:04 PM, Junio C Hamano wrote: > >> > >> 080739b (worktree.c: find_worktree() search by

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Antoine Tenart
On Tue, Jul 19, 2016 at 12:08:11PM -0700, Junio C Hamano wrote: > Antoine Tenart writes: > > > Being able to manually define the name can also be useful in some (rare) > > cases, where you reorganize your project directory tree. But that's not > > a strong argument for adding this option :-) > >

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Eric Sunshine
On Tue, Jul 19, 2016 at 3:04 PM, Duy Nguyen wrote: > On Tue, Jul 19, 2016 at 8:54 PM, Antoine Tenart wrote: >> Like moving a worktree (or is there a command for this?) > > Don't touch it. I've been waiting patiently for that patch series to > be reviewed :) For newcomers, "that patch series" ref

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Junio C Hamano
Antoine Tenart writes: > Being able to manually define the name can also be useful in some (rare) > cases, where you reorganize your project directory tree. But that's not > a strong argument for adding this option :-) Continuing the rationale that rejected the topic from the earlier discussion

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 8:54 PM, Antoine Tenart wrote: > On Tue, Jul 19, 2016 at 08:23:58PM +0200, Duy Nguyen wrote: >> On Tue, Jul 19, 2016 at 8:04 PM, Junio C Hamano wrote: >> >> 080739b (worktree.c: find_worktree() search by path suffix - >> 2016-06-13) from 'next' should help identify worktre

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Antoine Tenart
On Tue, Jul 19, 2016 at 08:23:58PM +0200, Duy Nguyen wrote: > On Tue, Jul 19, 2016 at 8:04 PM, Junio C Hamano wrote: > > 080739b (worktree.c: find_worktree() search by path suffix - > 2016-06-13) from 'next' should help identify worktrees in this case by > specifying 'project0/foo', 'project1/foo

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Eric Sunshine
On Tue, Jul 19, 2016 at 2:04 PM, Junio C Hamano wrote: > Antoine Tenart writes: >> Adds a --name option allowing to specify the name of a worktree when >> creating it. This allows to have multiple worktrees in directories >> having the same name (e.g. project0/foo, project1/foo etc...). This >> c

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Antoine Tenart
Hi, On Tue, Jul 19, 2016 at 11:04:59AM -0700, Junio C Hamano wrote: > > > Adds a --name option allowing to specify the name of a worktree when > > creating it. This allows to have multiple worktrees in directories > > having the same name (e.g. project0/foo, project1/foo etc...). This > > commit

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 8:04 PM, Junio C Hamano wrote: > Antoine Tenart writes: > >> Adds a --name option allowing to specify the name of a worktree when >> creating it. This allows to have multiple worktrees in directories >> having the same name (e.g. project0/foo, project1/foo etc...). This >>

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Junio C Hamano
Antoine Tenart writes: > Adds a --name option allowing to specify the name of a worktree when > creating it. This allows to have multiple worktrees in directories > having the same name (e.g. project0/foo, project1/foo etc...). This > commit keeps the previous behaviour by making it the default v

[PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Antoine Tenart
Adds a --name option allowing to specify the name of a worktree when creating it. This allows to have multiple worktrees in directories having the same name (e.g. project0/foo, project1/foo etc...). This commit keeps the previous behaviour by making it the default value, i.e. by using $(basename )