Re: [PATCH] userdiff: update Ada patterns

2014-02-03 Thread Adrian Johnson
On 03/02/14 10:05, Jeff King wrote: > On Sun, Feb 02, 2014 at 09:21:56PM +1030, Adrian Johnson wrote: >> - Fix bug in word regex for numbers >> - "|[0-9][-+0-9#_.eE]" >> + "|[-+0-9#_.eE]+" > > This makes "E" or "_" a number. Is that right? > > I think the intent of the original was "start

Re: [PATCH] userdiff: update Ada patterns

2014-02-02 Thread Jeff King
On Sun, Feb 02, 2014 at 09:21:56PM +1030, Adrian Johnson wrote: > - Allow extra space in "is new" and "is separate" > [...] > - "!^(.*[ \t])?(is new|renames|is separate)([ \t].*)?$\n" > + "!^(.*[ \t])?(is[ \t]+new|renames|is[ \t]+separate)([ \t].*)?$\n" I do not know anything about Ada

[PATCH] userdiff: update Ada patterns

2014-02-02 Thread Adrian Johnson
- Allow extra space in "is new" and "is separate" - Fix bug in word regex for numbers Signed-off-by: Adrian Johnson --- t/t4034/ada/expect | 2 +- userdiff.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t4034/ada/expect b/t/t4034/ada/expect index be2376e..a6