Re: [PATCH] upload-pack: teach deepen-relative in protocol v2

2019-01-10 Thread Junio C Hamano
Jonathan Tan writes: >> > This, when applied on top of ecbdaf08991, seems to break t5702.30, >> > at least for me. >> > >> > Tip of 'pu' in today's push-out will be broken as it has this patch >> > merged. >> > >> > Can somebody take a look? >> >> I can reproduce this. I'll investigate this fu

Re: [PATCH] upload-pack: teach deepen-relative in protocol v2

2019-01-10 Thread Jonathan Tan
> > This, when applied on top of ecbdaf08991, seems to break t5702.30, > > at least for me. > > > > Tip of 'pu' in today's push-out will be broken as it has this patch > > merged. > > > > Can somebody take a look? > > I can reproduce this. I'll investigate this further. In the meantime, > feel f

Re: [PATCH] upload-pack: teach deepen-relative in protocol v2

2019-01-10 Thread Jonathan Tan
> Junio C Hamano writes: > > > Josh Steadmon writes: > > > >> Looks good to me. > >> Reviewed-by: Josh Steadmon > > > > Thanks, both. > > This, when applied on top of ecbdaf08991, seems to break t5702.30, > at least for me. > > Tip of 'pu' in today's push-out will be broken as it has this pat

Re: [PATCH] upload-pack: teach deepen-relative in protocol v2

2019-01-10 Thread Junio C Hamano
Junio C Hamano writes: > Josh Steadmon writes: > >> Looks good to me. >> Reviewed-by: Josh Steadmon > > Thanks, both. This, when applied on top of ecbdaf08991, seems to break t5702.30, at least for me. Tip of 'pu' in today's push-out will be broken as it has this patch merged. Can somebody t

Re: [PATCH] upload-pack: teach deepen-relative in protocol v2

2019-01-10 Thread Junio C Hamano
Josh Steadmon writes: > Looks good to me. > Reviewed-by: Josh Steadmon Thanks, both.

Re: [PATCH] upload-pack: teach deepen-relative in protocol v2

2019-01-09 Thread Josh Steadmon
On 2018.12.18 13:24, Jonathan Tan wrote: > Commit 685fbd3291 ("fetch-pack: perform a fetch using v2", 2018-03-15) > attempted to teach Git deepen-relative in protocol v2 (among other > things), but it didn't work: > > (1) fetch-pack.c needs to emit "deepen-relative". > (2) upload-pack.c needs to

[PATCH] upload-pack: teach deepen-relative in protocol v2

2018-12-18 Thread Jonathan Tan
Commit 685fbd3291 ("fetch-pack: perform a fetch using v2", 2018-03-15) attempted to teach Git deepen-relative in protocol v2 (among other things), but it didn't work: (1) fetch-pack.c needs to emit "deepen-relative". (2) upload-pack.c needs to ensure that the correct deepen_relative variabl