Re: [PATCH] upload-pack: allow shallow fetching from a read-only repository

2014-02-27 Thread Duy Nguyen
On Thu, Feb 27, 2014 at 4:04 PM, Jeff King wrote: > This is not introduced by your patch, but I notice that we do not seem > to do anything with the tempfiles when the program dies prematurely. > We've started collecting stale shallow_XX files in our server repos. > > For the writable cases, s

Re: [PATCH] upload-pack: allow shallow fetching from a read-only repository

2014-02-27 Thread Jeff King
On Thu, Feb 27, 2014 at 02:13:03PM +0700, Nguyễn Thái Ngọc Duy wrote: > Before cdab485 (upload-pack: delegate rev walking in shallow fetch to > pack-objects - 2013-08-16) upload-pack does not write to the source > repository. cdab485 starts to write $GIT_DIR/shallow_XX if it's a > shallow fetc

[PATCH] upload-pack: allow shallow fetching from a read-only repository

2014-02-26 Thread Nguyễn Thái Ngọc Duy
Before cdab485 (upload-pack: delegate rev walking in shallow fetch to pack-objects - 2013-08-16) upload-pack does not write to the source repository. cdab485 starts to write $GIT_DIR/shallow_XX if it's a shallow fetch, so the source repo must be writable. Fall back to $TMPDIR if $GIT_DIR/shall