Re: [PATCH] update-index: Don't copy memory around

2015-03-23 Thread Junio C Hamano
Stefan Beller writes: > ... though I do not understand > why. This passes the test suite, so I wonder if this patch would be a subtle > bug > now. I recall the last time I traced the code I noticed that the ce can get passed to a codepath that causes its removal from update_one(), and then the

[PATCH] update-index: Don't copy memory around

2015-03-23 Thread Stefan Beller
Signed-off-by: Stefan Beller --- On Fri, Mar 20, 2015 at 8:40 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> `old` is not used outside the loop and would get lost >> once we reach the goto. >> >> Signed-off-by: Stefan Beller >> --- >>  builtin/update-index.c | 1 + >>  1 file changed, 1