Re: [PATCH] unpack_entry: invalidate newly added cache entry in case of error

2013-04-30 Thread Junio C Hamano
Thomas Rast writes: > Duy Nguyen writes: > >> Apply this patch on top of master (no need to apply full series) and run >> t5303 >> >> http://article.gmane.org/gmane.comp.version-control.git/222895 > [...] >> OK since you know this code much better than me, I withdraw my patch >> (consider it a

Re: [PATCH] unpack_entry: invalidate newly added cache entry in case of error

2013-04-30 Thread Duy Nguyen
On Tue, Apr 30, 2013 at 7:53 PM, Thomas Rast wrote: > Duy Nguyen writes: > >> Apply this patch on top of master (no need to apply full series) and run >> t5303 >> >> http://article.gmane.org/gmane.comp.version-control.git/222895 > [...] >> OK since you know this code much better than me, I withd

Re: [PATCH] unpack_entry: invalidate newly added cache entry in case of error

2013-04-30 Thread Thomas Rast
Duy Nguyen writes: > Apply this patch on top of master (no need to apply full series) and run t5303 > > http://article.gmane.org/gmane.comp.version-control.git/222895 [...] > OK since you know this code much better than me, I withdraw my patch > (consider it a bug report) and let you work on a pr

Re: [PATCH] unpack_entry: invalidate newly added cache entry in case of error

2013-04-30 Thread Duy Nguyen
On Tue, Apr 30, 2013 at 3:27 PM, Thomas Rast wrote: > Nguyễn Thái Ngọc Duy writes: > >> In this particular code path, we add "base" to the delta base >> cache. Then decide to free it, but we forgot about a dangling pointer >> in the cache. Invalidate that entry when we free "base". >> >> Signed-o

Re: [PATCH] unpack_entry: invalidate newly added cache entry in case of error

2013-04-30 Thread Thomas Rast
Nguyễn Thái Ngọc Duy writes: > In this particular code path, we add "base" to the delta base > cache. Then decide to free it, but we forgot about a dangling pointer > in the cache. Invalidate that entry when we free "base". > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > Some of my changes trig

[PATCH] unpack_entry: invalidate newly added cache entry in case of error

2013-04-29 Thread Nguyễn Thái Ngọc Duy
In this particular code path, we add "base" to the delta base cache. Then decide to free it, but we forgot about a dangling pointer in the cache. Invalidate that entry when we free "base". Signed-off-by: Nguyễn Thái Ngọc Duy --- Some of my changes triggered a double free fault at "free(base);" i