Re: [PATCH] travis-ci: ignore already tested trees in debug mode

2019-09-20 Thread SZEDER Gábor
On Fri, Sep 20, 2019 at 11:28:11AM -0700, Junio C Hamano wrote: > SZEDER Gábor writes: > > >> But in the larger picture, I would expect that readers would more > >> immediately grasp what it is about if it were titled "do not skip > >> versions that have already tested good in debug mode" > > > >

Re: [PATCH] travis-ci: ignore already tested trees in debug mode

2019-09-20 Thread Junio C Hamano
SZEDER Gábor writes: >> But in the larger picture, I would expect that readers would more >> immediately grasp what it is about if it were titled "do not skip >> versions that have already tested good in debug mode" > > Will try to come up with a better subject line, but I don't have any > usable

Re: [PATCH] travis-ci: ignore already tested trees in debug mode

2019-09-20 Thread SZEDER Gábor
On Fri, Sep 20, 2019 at 11:03:48AM -0700, Junio C Hamano wrote: > SZEDER Gábor writes: > > > skip_good_tree () { > > + if test "$TRAVIS_DEBUG_MODE" = true > > + then > > + return > > + fi > > I think you convinced readers why it is a good idea to avoid > skipping an already test

Re: [PATCH] travis-ci: ignore already tested trees in debug mode

2019-09-20 Thread Junio C Hamano
SZEDER Gábor writes: > skip_good_tree () { > + if test "$TRAVIS_DEBUG_MODE" = true > + then > + return > + fi I think you convinced readers why it is a good idea to avoid skipping an already tested tree, and technically the title of this commit is not incorrect per-se.

[PATCH] travis-ci: ignore already tested trees in debug mode

2019-09-19 Thread SZEDER Gábor
Travis CI offers shell access to its virtual machine environment running the build jobs, called "debug mode" [1]. After restarting a build job in debug mode and logging in, the first thing I usually do is to install dependencies, i.e. run './ci/install-dependencies.sh'. This works just fine when I