Re: [PATCH] transport-helper: do not request symbolic refs to remote helpers

2015-01-22 Thread Junio C Hamano
Mike Hommey writes: > On Thu, Jan 22, 2015 at 09:52:55AM -0800, Junio C Hamano wrote: > >> Does the new code avoid regressions for them and if so how? That is >> what was needed in the justification. >> >> For remote helpers that support the 'list' command, asking for a >> symref and asking for

Re: [PATCH] transport-helper: do not request symbolic refs to remote helpers

2015-01-22 Thread Mike Hommey
On Thu, Jan 22, 2015 at 09:52:55AM -0800, Junio C Hamano wrote: > Mike Hommey writes: > > > The patch changes the behavior in all cases, because it didn't feel > > necessary to have a different behavior between the "normal" case and the > > '?' case: it makes sense to request the ref being pointe

Re: [PATCH] transport-helper: do not request symbolic refs to remote helpers

2015-01-22 Thread Junio C Hamano
Mike Hommey writes: > The patch changes the behavior in all cases, because it didn't feel > necessary to have a different behavior between the "normal" case and the > '?' case: it makes sense to request the ref being pointed at than the > symbolic ref in every case. > > Moreover, this makes exist

Re: [PATCH] transport-helper: do not request symbolic refs to remote helpers

2015-01-22 Thread Mike Hommey
On Wed, Jan 21, 2015 at 11:41:51PM -0800, Junio C Hamano wrote: > Mike Hommey writes: > > > Note the most important part is actually between the parens: that only > > happens when the remote helper returns '?' to the `list` command, which > > non-git remotes helpers (like git-remote-hg or git-rem

Re: [PATCH] transport-helper: do not request symbolic refs to remote helpers

2015-01-21 Thread Junio C Hamano
Mike Hommey writes: > Note the most important part is actually between the parens: that only > happens when the remote helper returns '?' to the `list` command, which > non-git remotes helpers (like git-remote-hg or git-remote-bzr) do. > git-remote-testgit also does, so if you only apply the test

Re: [PATCH] transport-helper: do not request symbolic refs to remote helpers

2015-01-21 Thread Mike Hommey
On Wed, Jan 21, 2015 at 10:46:48PM -0800, Junio C Hamano wrote: > Mike Hommey writes: > > > A typical remote helper will return a `list` of refs containing a symbolic > > ref HEAD, pointing to, e.g. refs/heads/master. In the case of a clone, all > > the refs are being requested through `fetch` or

Re: [PATCH] transport-helper: do not request symbolic refs to remote helpers

2015-01-21 Thread Junio C Hamano
Mike Hommey writes: > A typical remote helper will return a `list` of refs containing a symbolic > ref HEAD, pointing to, e.g. refs/heads/master. In the case of a clone, all > the refs are being requested through `fetch` or `import`, including the > symbolic ref. > > While this works properly, in

[PATCH] transport-helper: do not request symbolic refs to remote helpers

2015-01-18 Thread Mike Hommey
A typical remote helper will return a `list` of refs containing a symbolic ref HEAD, pointing to, e.g. refs/heads/master. In the case of a clone, all the refs are being requested through `fetch` or `import`, including the symbolic ref. While this works properly, in some cases of a fetch, like `git