Re: [PATCH] trace2: fix incorrect function pointer check

2019-04-29 Thread Jeff Hostetler
On 4/25/2019 1:08 PM, Josh Steadmon wrote: Fix trace2_data_json_fl() to check for the presence of pfn_data_json_fl in its targets, rather than pfn_data_fl, which is not actually called. Signed-off-by: Josh Steadmon --- trace2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [PATCH] trace2: fix incorrect function pointer check

2019-04-25 Thread Junio C Hamano
Derrick Stolee writes: > On 4/25/2019 1:08 PM, Josh Steadmon wrote: >> Fix trace2_data_json_fl() to check for the presence of pfn_data_json_fl >> in its targets, rather than pfn_data_fl, which is not actually called. > > [snip] > >> for_each_wanted_builtin (j, tgt_j) >> -if (tgt_

Re: [PATCH] trace2: fix incorrect function pointer check

2019-04-25 Thread Derrick Stolee
On 4/25/2019 1:08 PM, Josh Steadmon wrote: > Fix trace2_data_json_fl() to check for the presence of pfn_data_json_fl > in its targets, rather than pfn_data_fl, which is not actually called. [snip] > for_each_wanted_builtin (j, tgt_j) > - if (tgt_j->pfn_data_fl) > + i

[PATCH] trace2: fix incorrect function pointer check

2019-04-25 Thread Josh Steadmon
Fix trace2_data_json_fl() to check for the presence of pfn_data_json_fl in its targets, rather than pfn_data_fl, which is not actually called. Signed-off-by: Josh Steadmon --- trace2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace2.c b/trace2.c index 8bbad56887..a73cf