Re: [PATCH] test-path-utils: use xsnprintf in favor of strcpy

Hi Peff, On Mon, 8 Feb 2016, Jeff King wrote: > This strcpy will never overflow because it's copying from > baked-in test data. But we would prefer to avoid strcpy > entirely, as it makes it harder to audit for real security > bugs. > > Signed-off-by: Jeff King ACK, of course. Thanks! Dscho -

Re: [PATCH] test-path-utils: use xsnprintf in favor of strcpy

On Mon, Feb 08, 2016 at 11:07:26PM +, Eric Wong wrote: > Jeff King wrote: > > Repost of <20160114202608.ga8...@sigill.intra.peff.net> from a few weeks > > ago (sorry, gmane is down so I can't generate a link). > > I prefer we use links derived from Message-IDs anyways. This > prevents relia

Re: [PATCH] test-path-utils: use xsnprintf in favor of strcpy

Jeff King wrote: > Repost of <20160114202608.ga8...@sigill.intra.peff.net> from a few weeks > ago (sorry, gmane is down so I can't generate a link). I prefer we use links derived from Message-IDs anyways. This prevents reliance on gmane article numbers being a central point of failure: http://m

Re: [PATCH] test-path-utils: use xsnprintf in favor of strcpy

Jeff King writes: > This strcpy will never overflow because it's copying from > baked-in test data. But we would prefer to avoid strcpy > entirely, as it makes it harder to audit for real security > bugs. > > Signed-off-by: Jeff King > --- > Repost of <20160114202608.ga8...@sigill.intra.peff.net

[PATCH] test-path-utils: use xsnprintf in favor of strcpy

This strcpy will never overflow because it's copying from baked-in test data. But we would prefer to avoid strcpy entirely, as it makes it harder to audit for real security bugs. Signed-off-by: Jeff King --- Repost of <20160114202608.ga8...@sigill.intra.peff.net> from a few weeks ago (sorry, gman