Re: [PATCH] test-lib-functions: fix logic error in test_must_fail

On Wed, Nov 25, 2015 at 12:05:36AM +, Ramsay Jones wrote: > > ... > > if ! list_contains "$_test_ok" success && test "$exit_code" -eq 0 > > then > > return 0 > > fi > ^^ > Is this intended to be part of the if..elif.. chain, or a separate > initial conditional? Hmm, actually it

Re: [PATCH] test-lib-functions: fix logic error in test_must_fail

On 24/11/15 21:08, Jeff King wrote: > On Tue, Nov 24, 2015 at 03:59:24PM +, Ramsay Jones wrote: > >> After commit 710eb805 ("implement test_might_fail using a refactored >> test_must_fail", 19-11-2015) several tests now unexpectedly pass: > > Thanks. I noticed there were some new passes, bu

Re: [PATCH] test-lib-functions: fix logic error in test_must_fail

On Tue, Nov 24, 2015 at 03:59:24PM +, Ramsay Jones wrote: > After commit 710eb805 ("implement test_might_fail using a refactored > test_must_fail", 19-11-2015) several tests now unexpectedly pass: Thanks. I noticed there were some new passes, but I hadn't investigated yet (I assumed it was "y

[PATCH] test-lib-functions: fix logic error in test_must_fail

After commit 710eb805 ("implement test_might_fail using a refactored test_must_fail", 19-11-2015) several tests now unexpectedly pass: $ tail -21 ptest-out [17:25:53] All tests successful. Test Summary Report --- t1060-object-corruption.sh (Wstat