Re: [PATCH] test-lib: fix non-portable pattern bracket expressions

2019-02-12 Thread Carlo Arenas
On Mon, Feb 11, 2019 at 4:35 PM Jeff King wrote: > > Ah, doubly puzzling. It works fine in my Debian dash (but fnmatch was > enabled in 0.5.8-1 there, too). FWIW, it is reported by both checkbashisms and shellcheck if "linting" could be considered of help to track these kind of issues. other "po

Re: [PATCH] test-lib: fix non-portable pattern bracket expressions

2019-02-11 Thread Jeff King
On Tue, Feb 12, 2019 at 01:30:18AM +0100, SZEDER Gábor wrote: > > I learn > > another one. :) Thanks for fixing this, and for digging up the POSIX > > reference. > > I had to, that 16.04's dash worked, but neither dash in older LTS nor > newer upstream version did was particularly puzzling. Turn

Re: [PATCH] test-lib: fix non-portable pattern bracket expressions

2019-02-11 Thread SZEDER Gábor
On Mon, Feb 11, 2019 at 06:46:26PM -0500, Jeff King wrote: > On Mon, Feb 11, 2019 at 08:58:03PM +0100, SZEDER Gábor wrote: > > > Use a '!' character to start a non-matching pattern bracket > > expression, as specified by POSIX in Shell Command Language section > > 2.13.1 Patterns Matching a Single

Re: [PATCH] test-lib: fix non-portable pattern bracket expressions

2019-02-11 Thread Jeff King
On Mon, Feb 11, 2019 at 08:58:03PM +0100, SZEDER Gábor wrote: > Use a '!' character to start a non-matching pattern bracket > expression, as specified by POSIX in Shell Command Language section > 2.13.1 Patterns Matching a Single Character [1]. Just when I think I know every little gotcha in the

Re: [PATCH] test-lib: fix non-portable pattern bracket expressions

2019-02-11 Thread Junio C Hamano
SZEDER Gábor writes: > Use a '!' character to start a non-matching pattern bracket > expression, as specified by POSIX in Shell Command Language section > 2.13.1 Patterns Matching a Single Character [1]. > > I used '^' instead in three places in the previous three commits, to Ah, thanks for catc

[PATCH] test-lib: fix non-portable pattern bracket expressions

2019-02-11 Thread SZEDER Gábor
Use a '!' character to start a non-matching pattern bracket expression, as specified by POSIX in Shell Command Language section 2.13.1 Patterns Matching a Single Character [1]. I used '^' instead in three places in the previous three commits, to verify that the arguments of the '--stress=' and '--