Re: [PATCH] tag.c: move PGP verification code from plumbing

2016-03-25 Thread Eric Sunshine
On Fri, Mar 25, 2016 at 10:45 AM, Santiago Torres wrote: >> > while (i < argc) >> > - if (verify_tag(argv[i++], flags)) >> > + name = argv[i++]; >> > + if (get_sha1(name, sha1)) >> > + return error("tag '%s' not found.", name)

Re: [PATCH] tag.c: move PGP verification code from plumbing

2016-03-25 Thread Santiago Torres
> > - signal(SIGPIPE, SIG_IGN); > > while (i < argc) > > - if (verify_tag(argv[i++], flags)) > > + name = argv[i++]; > > + if (get_sha1(name, sha1)) > > + return error("tag '%s' not found.", name); > > + > > +

Re: [PATCH] tag.c: move PGP verification code from plumbing

2016-03-24 Thread Jeff King
On Fri, Mar 25, 2016 at 01:23:57AM -0400, Eric Sunshine wrote: > On Thu, Mar 24, 2016 at 8:33 PM, wrote: > > The verify tag function is just a thin wrapper around the verify-tag > > command. We can avoid one fork call by doing the verification inside > > the tag builtin instead. > > Hopefully,

Re: [PATCH] tag.c: move PGP verification code from plumbing

2016-03-24 Thread Eric Sunshine
On Thu, Mar 24, 2016 at 8:33 PM, wrote: > The verify tag function is just a thin wrapper around the verify-tag > command. We can avoid one fork call by doing the verification inside > the tag builtin instead. Hopefully, the below review comments are meaningful, however, aside from having just re

[PATCH] tag.c: move PGP verification code from plumbing

2016-03-24 Thread santiago
From: Santiago Torres The verify tag function is just a thin wrapper around the verify-tag command. We can avoid one fork call by doing the verification inside the tag builtin instead. To do this, the run_pgp_verify() and verify_tag() functions are moved to tag.c. The definition of verify_tag wa