Re: [PATCH] t7406: submodule..update command must not be run from .gitmodules

2017-09-26 Thread Junio C Hamano
Stefan Beller writes: > submodule..update can be assigned an arbitrary command via setting > it to "!command". When this command is found in the regular config, Git > ought to just run that command instead of other update mechanisms. > > However if that command is just found in the .gitmodules fi

[PATCH] t7406: submodule..update command must not be run from .gitmodules

2017-09-26 Thread Stefan Beller
submodule..update can be assigned an arbitrary command via setting it to "!command". When this command is found in the regular config, Git ought to just run that command instead of other update mechanisms. However if that command is just found in the .gitmodules file, it is potentially untrusted,

Re: [PATCH] t7406: submodule..update command must not be run from .gitmodules

2017-09-26 Thread Johannes Sixt
Am 26.09.2017 um 20:54 schrieb Stefan Beller: +test_expect_success 'submodule update - command in .gitmodules is ignored' ' + test_when_finished "git -C super reset --hard HEAD^" && + + git -C super config -f .gitmodules submodule.submodule.update "!false" && + git -C super com

[PATCH] t7406: submodule..update command must not be run from .gitmodules

2017-09-26 Thread Stefan Beller
submodule..update can be assigned an arbitrary command via setting it to "!command". When this command is found in the regular config, Git ought to just run that command instead of other update mechanisms. However if that command is just found in the .gitmodules file, it is potentially untrusted,

Re: [PATCH] t7406: submodule..update command must not be run from .gitmodules

2017-09-25 Thread Junio C Hamano
Johannes Sixt writes: >> +test_when_finished "git -C super reset --hard HEAD^" && >> + >> +write_script must_not_run.sh <<-EOF && >> +>$TEST_DIRECTORY/bad >> +EOF > > I am pretty confident that this does not test what you intend to > test. Notice that $TEST_DIRECTORY is expanded w

Re: [PATCH] t7406: submodule..update command must not be run from .gitmodules

2017-09-25 Thread Johannes Sixt
Am 26.09.2017 um 00:50 schrieb Stefan Beller: submodule..update can be assigned an arbitrary command via setting it to "!command". When this command is found in the regular config, Git ought to just run that command instead of other update mechanisms. However if that command is just found in the

Re: [PATCH] t7406: submodule..update command must not be run from .gitmodules

2017-09-25 Thread Jonathan Nieder
Stefan Beller wrote: > submodule..update can be assigned an arbitrary command via setting > it to "!command". When this command is found in the regular config, Git > ought to just run that command instead of other update mechanisms. > > However if that command is just found in the .gitmodules file

[PATCH] t7406: submodule..update command must not be run from .gitmodules

2017-09-25 Thread Stefan Beller
submodule..update can be assigned an arbitrary command via setting it to "!command". When this command is found in the regular config, Git ought to just run that command instead of other update mechanisms. However if that command is just found in the .gitmodules file, it is potentially untrusted,

Re: [PATCH] t7406: submodule..update command must not be run from .gitmodules

2017-09-25 Thread Jonathan Nieder
Stefan Beller wrote: > submodule..update can be assigned an arbitrary command via setting > it to "!command". When this command is found in the regular config, Git > ought to just run that command instead of other update mechanisms. > > However if that command is just found in the .gitmodules fil

[PATCH] t7406: submodule..update command must not be run from .gitmodules

2017-09-25 Thread Stefan Beller
submodule..update can be assigned an arbitrary command via setting it to "!command". When this command is found in the regular config, Git ought to just run that command instead of other update mechanisms. However if that command is just found in the .gitmodules file, it is potentially untrusted,