Re: [PATCH] t6026: ensure that long-running script really is

2016-11-11 Thread Jeff King
On Fri, Nov 11, 2016 at 07:50:14AM +0100, Johannes Sixt wrote: > Shouldn't we then move the 'kill' out of test_when_finished and make > it a proper condition of the test? Like this? > > diff --git a/t/t6026-merge-attr.sh b/t/t6026-merge-attr.sh > index 348d78b205..6ad8bd098a 100755 > --- a/t/t602

Re: [PATCH] t6026: ensure that long-running script really is

2016-11-10 Thread Johannes Sixt
Am 11.11.2016 um 00:53 schrieb Junio C Hamano: > Johannes Schindelin writes: > >> When making sure that background tasks are cleaned up in 5babb5b >> (t6026-merge-attr: clean up background process at end of test case, >> 2016-09-07), we considered to let the background task sleep longer, just >>

Re: [PATCH] t6026: ensure that long-running script really is

2016-11-10 Thread Junio C Hamano
Johannes Schindelin writes: > When making sure that background tasks are cleaned up in 5babb5b > (t6026-merge-attr: clean up background process at end of test case, > 2016-09-07), we considered to let the background task sleep longer, just > to be certain that it will still be running when we wan

[PATCH] t6026: ensure that long-running script really is

2016-11-09 Thread Johannes Schindelin
When making sure that background tasks are cleaned up in 5babb5b (t6026-merge-attr: clean up background process at end of test case, 2016-09-07), we considered to let the background task sleep longer, just to be certain that it will still be running when we want to kill it after the test. Sadly, t