Re: [PATCH] t5541: don't call start_httpd after sourcing lib-terminal.sh

2014-03-14 Thread Junio C Hamano
Jeff King writes: > One option would be to _always_ define test_terminal That looks like the right direction to go. > Something like the patch below (looks like we should be using $PERL_PATH > instead of "perl", too). ;-) Also a SP between test_terminal and (), perhaps. > diff --git a/t/

Re: [PATCH] t5541: don't call start_httpd after sourcing lib-terminal.sh

2014-03-14 Thread Jeff King
On Fri, Mar 14, 2014 at 10:18:32PM +0100, Jens Lehmann wrote: > Since 83d842dc8 "make test" using prove fails for some setups in t5541 > with: > >"Parse errors: No plan found in TAP output" > > Running t5541 on its own fails with: > >"error: Can't use skip_all after running some tests"

[PATCH] t5541: don't call start_httpd after sourcing lib-terminal.sh

2014-03-14 Thread Jens Lehmann
Since 83d842dc8 "make test" using prove fails for some setups in t5541 with: "Parse errors: No plan found in TAP output" Running t5541 on its own fails with: "error: Can't use skip_all after running some tests" This happens because "start_httpd" (which determines if the test is to be skip